From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752283AbdGRVch (ORCPT ); Tue, 18 Jul 2017 17:32:37 -0400 Received: from mail-ua0-f180.google.com ([209.85.217.180]:33259 "EHLO mail-ua0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513AbdGRVcg (ORCPT ); Tue, 18 Jul 2017 17:32:36 -0400 From: Alexei Potashnik References: <20170718191829.GA11583@infradead.org> In-Reply-To: <20170718191829.GA11583@infradead.org> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGjC+bXdyQUOBB9RHZCYJYM4GHb2gJDHYnxoqfpOWA= Date: Tue, 18 Jul 2017 14:32:34 -0700 Message-ID: <33627bbb8ac8a2aa40ce79c6b82f0764@mail.gmail.com> Subject: RE: [PATCH] workqueue: doc change for ST behavior on NUMA systems To: Christoph Hellwig Cc: tj@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org target has a bug in TMR handling. dev->tmr_wq = alloc_workqueue("tmr-%s", WQ_MEM_RECLAIM | WQ_UNBOUND, 1, dev->transport->name); LUN_RESET can race with TASK_ABORT in different sessions. Will send a patch to target list. -----Original Message----- From: Christoph Hellwig [mailto:hch@infradead.org] Sent: Tuesday, July 18, 2017 12:18 PM To: Alexei Potashnik Cc: tj@kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] workqueue: doc change for ST behavior on NUMA systems On Tue, Jul 18, 2017 at 11:12:53AM -0700, Alexei Potashnik wrote: > NUMA rework of workqueue made the combination of max_active of 1 and > WQ_UNBOUND insufficient to guarantee ST behavior system wide. > > alloc_ordered_queue should now be used instead. Eww. And how many existing users might be broken by that?