From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933732AbdKGArA (ORCPT ); Mon, 6 Nov 2017 19:47:00 -0500 Received: from mail.efficios.com ([167.114.142.141]:41150 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932762AbdKGAq5 (ORCPT ); Mon, 6 Nov 2017 19:46:57 -0500 Date: Tue, 7 Nov 2017 00:47:17 +0000 (UTC) From: Mathieu Desnoyers To: Nicholas Piggin Cc: Peter Zijlstra , "Paul E. McKenney" , Boqun Feng , Andy Lutomirski , Dave Watson , Andrew Morton , Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org, linux-kernel Message-ID: <337041894.6072.1510015637355.JavaMail.zimbra@efficios.com> In-Reply-To: <20171107113729.13369a30@roar.ozlabs.ibm.com> References: <20171106092228.31098-1-mhocko@kernel.org> <1509992067.4140.1.camel@oracle.com> <20171106205644.29386-11-mathieu.desnoyers@efficios.com> <20171107113729.13369a30@roar.ozlabs.ibm.com> Subject: Re: [RFC PATCH for 4.15 10/14] cpu_opv: Wire up powerpc system call MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.142.141] X-Mailer: Zimbra 8.7.11_GA_1854 (ZimbraWebClient - FF52 (Linux)/8.7.11_GA_1854) Thread-Topic: cpu_opv: Wire up powerpc system call Thread-Index: Ubx9UfHFEqDbuN3HAQrysG5mlKZj6A== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On Nov 6, 2017, at 7:37 PM, Nicholas Piggin npiggin@gmail.com wrote: > On Mon, 6 Nov 2017 15:56:40 -0500 > Mathieu Desnoyers wrote: > >> diff --git a/arch/powerpc/include/uapi/asm/unistd.h >> b/arch/powerpc/include/uapi/asm/unistd.h >> index b1980fcd56d5..972a7d68c143 100644 >> --- a/arch/powerpc/include/uapi/asm/unistd.h >> +++ b/arch/powerpc/include/uapi/asm/unistd.h >> @@ -396,5 +396,6 @@ >> #define __NR_kexec_file_load 382 >> #define __NR_statx 383 >> #define __NR_rseq 384 >> +#define __NR_cpu_opv 385 > > Sorry for bike shedding, but could we invest a few more keystrokes to > make these names a bit more readable? Whenever I try to make variables or function names more explicit, I can literally feel my consciousness (taking the form of an angry Peter Zijlstra) breathing down my neck asking me to make them shorter. So I guess this is where it becomes a question of taste. I think the "rseq" syscall name is short, to the point, and should be mostly fine. For "cpu_opv", it was just a short name that fit the bill until a better idea would come. I'm open to suggestions. Any color preference ? ;-) Thanks, Mathieu > > Thanks, > Nick -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com