From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Daniel Borkmann <dborkman@redhat.com>,
"'Quentin Gouchet'" <quentin.gouchet@gmail.com>,
"'LKML'" <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, linux-api@vger.kernel.org
Subject: [PATCH v5 5/8] crypto: AF_ALG: add user space interface for RNG
Date: Sun, 07 Dec 2014 23:23:48 +0100 [thread overview]
Message-ID: <3380968.kTQNpvjKFa@tachyon.chronox.de> (raw)
In-Reply-To: <56740432.V2v4gLHrzS@tachyon.chronox.de>
Allow user space to seed / reset the RNG via a setsockopt.
This patch reuses alg_setkey to copy data into the kernel. The
alg_setkey is now used for two mechanisms: setkey and seeding.
The function is extended by the providing the function pointer
to the function handling the copied data.
As the alg_setkey is now usable for more than just setkey, it is renamed
to alg_setop.
Signed-off-by: Stephan Mueller <smueller@chronox.de>
---
crypto/af_alg.c | 29 +++++++++++++++++++----------
include/crypto/if_alg.h | 1 +
include/uapi/linux/if_alg.h | 1 +
3 files changed, 21 insertions(+), 10 deletions(-)
diff --git a/crypto/af_alg.c b/crypto/af_alg.c
index 547c369..d1eb1e9 100644
--- a/crypto/af_alg.c
+++ b/crypto/af_alg.c
@@ -169,26 +169,27 @@ static int alg_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
return 0;
}
-static int alg_setkey(struct sock *sk, char __user *ukey,
- unsigned int keylen)
+static int alg_setop(struct sock *sk, char __user *udata,
+ unsigned int datalen,
+ int (*handler)(void *private, const u8 *data,
+ unsigned int datalen))
{
struct alg_sock *ask = alg_sk(sk);
- const struct af_alg_type *type = ask->type;
- u8 *key;
+ u8 *data;
int err;
- key = sock_kmalloc(sk, keylen, GFP_KERNEL);
- if (!key)
+ data = sock_kmalloc(sk, datalen, GFP_KERNEL);
+ if (!data)
return -ENOMEM;
err = -EFAULT;
- if (copy_from_user(key, ukey, keylen))
+ if (copy_from_user(data, udata, datalen))
goto out;
- err = type->setkey(ask->private, key, keylen);
+ err = handler(ask->private, data, datalen);
out:
- sock_kfree_s(sk, key, keylen);
+ sock_kfree_s(sk, data, datalen);
return err;
}
@@ -214,7 +215,7 @@ static int alg_setsockopt(struct socket *sock, int level, int optname,
if (!type->setkey)
goto unlock;
- err = alg_setkey(sk, optval, optlen);
+ err = alg_setop(sk, optval, optlen, type->setkey);
break;
case ALG_SET_AEAD_AUTHSIZE:
if (sock->state == SS_CONNECTED)
@@ -222,6 +223,14 @@ static int alg_setsockopt(struct socket *sock, int level, int optname,
if (!type->setauthsize)
goto unlock;
err = type->setauthsize(ask->private, optlen);
+ break;
+ case ALG_SET_RNG_SEED:
+ if (sock->state == SS_CONNECTED)
+ goto unlock;
+ if (!type->setseed)
+ goto unlock;
+
+ err = alg_setop(sk, optval, optlen, type->setseed);
}
unlock:
diff --git a/include/crypto/if_alg.h b/include/crypto/if_alg.h
index 5c7b6c5..0808ed1 100644
--- a/include/crypto/if_alg.h
+++ b/include/crypto/if_alg.h
@@ -51,6 +51,7 @@ struct af_alg_type {
int (*setkey)(void *private, const u8 *key, unsigned int keylen);
int (*accept)(void *private, struct sock *sk);
int (*setauthsize)(void *private, unsigned int authsize);
+ int (*setseed)(void *private, const u8 *seed, unsigned int seedlen);
struct proto_ops *ops;
struct module *owner;
diff --git a/include/uapi/linux/if_alg.h b/include/uapi/linux/if_alg.h
index f2acd2f..973dcca 100644
--- a/include/uapi/linux/if_alg.h
+++ b/include/uapi/linux/if_alg.h
@@ -34,6 +34,7 @@ struct af_alg_iv {
#define ALG_SET_OP 3
#define ALG_SET_AEAD_ASSOCLEN 4
#define ALG_SET_AEAD_AUTHSIZE 5
+#define ALG_SET_RNG_SEED 6
/* Operations */
#define ALG_OP_DECRYPT 0
--
2.1.0
next prev parent reply other threads:[~2014-12-07 22:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 22:20 [PATCH v5 0/8] crypto: AF_ALG: add AEAD and RNG support Stephan Mueller
2014-12-07 22:21 ` [PATCH v5 1/8] crypto: AF_ALG: add user space interface for AEAD Stephan Mueller
2014-12-08 6:50 ` Stephan Mueller
2014-12-07 22:21 ` [PATCH v5 2/8] crypto: AF_ALG: add setsockopt for auth tag size Stephan Mueller
2014-12-22 12:05 ` Herbert Xu
2014-12-07 22:22 ` [PATCH v5 3/8] crypto: AF_ALG: add AEAD support Stephan Mueller
2014-12-22 11:23 ` Herbert Xu
2014-12-23 8:14 ` Stephan Mueller
2014-12-23 11:56 ` Herbert Xu
2014-12-23 14:52 ` Stephan Mueller
2014-12-23 20:24 ` Herbert Xu
2014-12-24 8:54 ` Stephan Mueller
2014-12-25 8:59 ` Stephan Mueller
2014-12-25 20:28 ` Herbert Xu
2014-12-07 22:23 ` [PATCH v5 4/8] crypto: AF_ALG: enable AEAD interface compilation Stephan Mueller
2014-12-07 22:23 ` Stephan Mueller [this message]
2014-12-22 11:27 ` [PATCH v5 5/8] crypto: AF_ALG: add user space interface for RNG Herbert Xu
2014-12-23 8:27 ` Stephan Mueller
2014-12-07 22:24 ` [PATCH v5 6/8] crypto: AF_ALG: zeroize key / seed data Stephan Mueller
2014-12-07 22:25 ` [PATCH v5 7/8] crypto: AF_ALG: add random number generator support Stephan Mueller
2014-12-07 22:25 ` [PATCH v5 8/8] crypto: AF_ALG: enable RNG interface compilation Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3380968.kTQNpvjKFa@tachyon.chronox.de \
--to=smueller@chronox.de \
--cc=dborkman@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-api@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quentin.gouchet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox