From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937399AbdJQTJR (ORCPT ); Tue, 17 Oct 2017 15:09:17 -0400 Received: from gloria.sntech.de ([95.129.55.99]:41498 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753816AbdJQTJQ (ORCPT ); Tue, 17 Oct 2017 15:09:16 -0400 From: Heiko Stuebner To: Jagan Teki Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Mark Rutland , Russell King , Michael Trimarchi , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jagan Teki Subject: Re: [PATCH 2/9] ARM: dts: rockchip: rk3288-vyasa: Use fixed voltage range for vccio_sd Date: Tue, 17 Oct 2017 21:09:04 +0200 Message-ID: <3394467.76otEihhKb@phil> User-Agent: KMail/5.2.3 (Linux/4.11.0-1-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1508156187-27519-3-git-send-email-jagan@amarulasolutions.com> References: <1508156187-27519-1-git-send-email-jagan@amarulasolutions.com> <1508156187-27519-3-git-send-email-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am Montag, 16. Oktober 2017, 17:46:20 CEST schrieb Jagan Teki: > vccio_sd has supplied to vqmmc-supply for sdmmc, use fixed voltage > range of 3.3v for better IO lines supply voltage. > > Signed-off-by: Jagan Teki not sure I understand this one. I.e. the regulator should be at 3.3V anyway and only when it reaches UHS speeds should the mmc core reduce the voltage to 1.8V, so having this variable here, shouldn't pose a problem? So maybe you could explain a bit more what the problem is? Thanks Heiko > --- > arch/arm/boot/dts/rk3288-vyasa.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/rk3288-vyasa.dts b/arch/arm/boot/dts/rk3288-vyasa.dts > index 7a0f945..915b4a3 100644 > --- a/arch/arm/boot/dts/rk3288-vyasa.dts > +++ b/arch/arm/boot/dts/rk3288-vyasa.dts > @@ -214,7 +214,7 @@ > > vccio_sd: LDO_REG5 { > regulator-name = "vccio_sd"; > - regulator-min-microvolt = <1800000>; > + regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > regulator-always-on; > regulator-boot-on; >