From: Christian Lamparter <chunkeey@googlemail.com>
To: Julian Margetson <runaway@candw.ms>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Tejun Heo" <tj@kernel.org>,
linux-ide@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Måns Rullgård" <mans@mansr.com>
Subject: Re: [PATCH v1 00/23] ata: sata_dwc_460ex: make it working again
Date: Sun, 24 Apr 2016 17:21:26 +0200 [thread overview]
Message-ID: <33998356.WVR1zQ2T7Q@debian64> (raw)
In-Reply-To: <571CC4A7.8050808@candw.ms>
On Sunday, April 24, 2016 09:05:43 AM Julian Margetson wrote:
> On 4/23/2016 3:41 PM, Christian Lamparter wrote:
> > There's a known errata for the 460EX, with the CPU lockup upon
> > high AHB traffic:
> > <http://lists.denx.de/pipermail/u-boot/2008-June/036078.html>
> >
> > "This patch implements a fix provided by AMCC so that the lockup upon
> > simultanious traffic on AHB USB OTG, USB 2.0 and SATA doesn't occur
> > anymore:..."
> >
> > This should be fixed by u-boot. However, there's no telling if
> > there's more to this workaround in the dma engine. You could try
> > to do the testing without anything connected to the USB ports
> > and disable/remove all usb hcds modules. As for fixing this:
> > I did a quick search but couldn't find any public information.
> > There's always support@apm.com (contact them!), or maybe someone
> > from the Amiga community knows more?
> >
> >
>
> Tested with kernel with all USB disabled. No sata error messages
> during the partition copy but the copying is quite slow.
Ok. The CONFIG_DMADEVICES_DEBUG and CONFIG_DMADEVICES_VDEBUG option
have quite a large overhead, if this fixed the issue for now you
could try to disable them and look if the issue comes back or not.
(also, you can drop the mdelay patch if it's still applied). If
the issue doesn't come back, you could add your "Tested-by" tag
too.
Another thing, the sata dwc driver doesn't yet support NCQ. Do you
know if the driver for the Amiga OS does?
> so this does appear to be the problem.
So, how to fix this? I know, there's an AHB DMA Arbiter. But I can't
get any documentation for it from AMCC/APM. Maybe denx.de or someone
from the Amiga community knows how to deal with it. In theory, we
could try if limiting the burst length, pending dma request count or
add code to retry failed dma transfers and reinit the usb-cores would
help.
Regards,
Christian
next prev parent reply other threads:[~2016-04-24 15:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 18:15 [PATCH v1 00/23] ata: sata_dwc_460ex: make it working again Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 01/23] ata: sata_dwc_460ex: remove incorrect locking Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 02/23] ata: sata_dwc_460ex: fix crash on offline links without an attached drive Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 03/23] ata: sata_dwc_460ex: set dma_boundary to 0x1fff Andy Shevchenko
2016-04-22 13:13 ` Sergei Shtylyov
2016-04-21 18:15 ` [PATCH v1 04/23] ata: sata_dwc_460ex: burst size must be in items not bytes Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 05/23] ata: sata_dwc_460ex: DMA is always a flow controller Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 06/23] ata: sata_dwc_460ex: select only core part of DMA driver Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 07/23] ata: sata_dwc_460ex: skip dma setup for non-dma commands Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 08/23] ata: sata_dwc_460ex: don't call ata_sff_qc_issue() on DMA commands Andy Shevchenko
2016-04-22 11:32 ` David Laight
2016-04-22 11:44 ` Christian Lamparter
2016-04-21 18:15 ` [PATCH v1 09/23] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 10/23] ata: sata_dwc_460ex: add phy support Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 11/23] ata: sata_dwc_460ex: get rid of global data Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 12/23] ata: sata_dwc_460ex: correct HOSTDEV{P}_FROM_*() macros Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 13/23] ata: sata_dwc_460ex: remove empty libata callback Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 14/23] ata: sata_dwc_460ex: get rid of some pointless casts Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 15/23] ata: sata_dwc_460ex: get rid of incorrect cast Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 16/23] ata: sata_dwc_460ex: add __iomem to register base pointer Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 17/23] ata: sata_dwc_460ex: supply physical address of FIFO to DMA Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 18/23] ata: sata_dwc_460ex: switch to new dmaengine_terminate_* API Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 19/23] ata: sata_dwc_460ex: use readl/writel_relaxed() Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 20/23] ata: sata_dwc_460ex: tidy up sata_dwc_clear_dmacr() Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 21/23] ata: sata_dwc_460ex: use devm_ioremap Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 22/23] ata: sata_dwc_460ex: make debug messages neat Andy Shevchenko
2016-04-21 18:15 ` [PATCH v1 23/23] powerpc/4xx: Device tree update for the 460ex DWC SATA Andy Shevchenko
2016-04-21 19:59 ` Rob Herring
2016-04-21 20:25 ` [PATCH v1 00/23] ata: sata_dwc_460ex: make it working again Christian Lamparter
2016-04-22 10:50 ` Julian Margetson
2016-04-22 11:06 ` Christian Lamparter
2016-04-23 12:02 ` Julian Margetson
2016-04-23 15:44 ` Julian Margetson
2016-04-23 19:41 ` Christian Lamparter
2016-04-24 13:05 ` Julian Margetson
2016-04-24 15:21 ` Christian Lamparter [this message]
2016-04-24 17:51 ` Julian Margetson
2016-04-23 15:44 ` Julian Margetson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33998356.WVR1zQ2T7Q@debian64 \
--to=chunkeey@googlemail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mans@mansr.com \
--cc=robh+dt@kernel.org \
--cc=runaway@candw.ms \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).