From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758953AbdEOHxu (ORCPT ); Mon, 15 May 2017 03:53:50 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35124 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758399AbdEOHxs (ORCPT ); Mon, 15 May 2017 03:53:48 -0400 Subject: Re: [PATCH v3 3/9] dt-bindings: arm: mediatek: update for MT7623n SoC and relevant boards To: sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, john@phrozen.org, linux-mediatek@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: From: Matthias Brugger Message-ID: <33b3a8a3-006b-91b3-e30d-56518fb9ae7a@gmail.com> Date: Mon, 15 May 2017 09:53:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/17 09:56, sean.wang@mediatek.com wrote: > From: Sean Wang > > Because there are two versions of MT7623 SoC that is MT7623a and MT7623n > respectively. So update the part of MT7623n bindings to allow that people > tend to differentiate which MT7623 SoC the boards applies. > > Signed-off-by: John Crispin > Signed-off-by: Sean Wang > --- > Documentation/devicetree/bindings/arm/mediatek.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.txt b/Documentation/devicetree/bindings/arm/mediatek.txt > index c860b24..0924b62 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.txt > +++ b/Documentation/devicetree/bindings/arm/mediatek.txt > @@ -1,6 +1,6 @@ > MediaTek mt65xx, mt67xx & mt81xx Platforms Device Tree Bindings > > -Boards with a MediaTek mt65xx/mt67xx/mt81xx SoC shall have the > +Boards with a MediaTek mt65xx/mt67xx/mt762x/mt81xx SoC shall have the > following property: > > Required root node property: > @@ -12,7 +12,7 @@ compatible: Must contain one of > "mediatek,mt6592" > "mediatek,mt6755" > "mediatek,mt6795" > - "mediatek,mt7623" > + "mediatek,mt7623" which is referred to MT7623N SoC > "mediatek,mt8127" > "mediatek,mt8135" > "mediatek,mt8173" > @@ -38,9 +38,9 @@ Supported boards: > - Evaluation board for MT6795(Helio X10): > Required root node properties: > - compatible = "mediatek,mt6795-evb", "mediatek,mt6795"; > -- Evaluation board for MT7623: > +- Reference board for MT7623n with NAND: > Required root node properties: > - - compatible = "mediatek,mt7623-evb", "mediatek,mt7623"; > + - compatible = "mediatek,mt7623n-rfb-nand", "mediatek,mt7623"; Please explain in the commit message why you change this binding and why this is not problematic. Either in this patch or add a new one. For convenience for the device-tree maintainer, add the binding patches at the beginning of your patch list. It makes their life easier and a review faster, a clear win-win situation :) Thanks, Matthias > - MTK mt8127 tablet moose EVB: > Required root node properties: > - compatible = "mediatek,mt8127-moose", "mediatek,mt8127"; >