Re: [PATCH v11 3/7] dt-bindings: PCI: qcom: Use sdx55 reg description for ipq9574

Krzysztof Kozlowski
2025-03-11T09:52:35Z

On 11/03/2025 09:16, Varadarajan Narayanan wrote:
>> I don't understand what is duplication of something here.
>
> By duplication, I meant the same set of reg-names (in different order).
>
>>> if (adding mhi to ipq9574 reg-names != duplication)
>>>
>>> /* Keep existing order */
>>>
>>> * Append "mhi" to ipq9574
>>
>> ipq9574 does not have mhi, does it?
>
> ipq9574 also has it.

Current binding says no, so something is missing.

>
>> If it has, it should be separate patch with its own explanation of the
>> hardware.
>
> Will discard these patches from the patchset -
>
> dt-bindings: PCI: qcom: Use sdx55 reg description for ipq9574 Varadarajan Narayanan
> arm64: dts: qcom: ipq9574: Reorder reg and reg-names Varadarajan Narayanan
>
> Will add mhi for ipq9574 and post the next version. Is that ok?

Yes.

Best regards,
Krzysztof