From: Segher Boessenkool <segher@kernel.crashing.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: akpm <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] math-emu/setcc: avoid gcc extension
Date: Sun, 7 Jan 2007 14:27:32 +0100 [thread overview]
Message-ID: <33e707f92df6b89a1c22f337f230cf32@kernel.crashing.org> (raw)
In-Reply-To: <20070106221947.8e01d404.randy.dunlap@oracle.com>
> setcc() in math-emu is written as a gcc extension statement expression
> macro that returns a value. However, it's not used that way and it's
> not needed like that, so just make it a do-while non-extension macro
> so that we don't use an extension when it's not needed.
Looks fine, except
> -#define setcc(cc) ({ \
> +#define setcc(cc) do { \
> partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \
> - partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); })
> + partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); } \
> + while (0)
closing brace on the "while" line, please.
Segher
next prev parent reply other threads:[~2007-01-07 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-07 6:19 [PATCH] math-emu/setcc: avoid gcc extension Randy Dunlap
2007-01-07 13:27 ` Segher Boessenkool [this message]
2007-01-07 18:45 ` Randy Dunlap
2007-01-07 19:12 ` Segher Boessenkool
2007-01-07 19:19 ` Randy Dunlap
2007-01-07 19:22 ` Robert P. J. Day
2007-01-07 19:29 ` Segher Boessenkool
2007-01-07 19:30 ` Randy Dunlap
2007-01-07 19:58 ` Christoph Hellwig
2007-01-07 21:07 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33e707f92df6b89a1c22f337f230cf32@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox