From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dzmitry Sankouski <dsankouski@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>, Lee Jones <lee@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: max77705: rework interrupts
Date: Sun, 31 Aug 2025 10:29:55 +0200 [thread overview]
Message-ID: <33eb49c4-aacf-46ec-a7c2-94ec8cba0243@kernel.org> (raw)
In-Reply-To: <20250831-max77705-fix_interrupt_handling-v1-1-73e078012e51@gmail.com>
On 31/08/2025 00:13, Dzmitry Sankouski wrote:
> Current implementation describes only MFD's own topsys interrupts.
> However, max77705 has a register which indicates interrupt source, i.e.
> it acts as an interrupt controller. There's 4 interrupt sources in
> max77705: topsys, charger, fuelgauge, usb type-c manager.
>
> Setup max77705 MFD parent as an interrupt controller. Leave topsys
> interrupts unregistered, because currently unused.
Then you should remove them from the driver.
>
> Fixes: c8d50f029748 ("mfd: Add new driver for MAX77705 PMIC")
>
No blank lines between the tags.
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Max77705 has a register, which indicates, who is triggering irq. There
> may be 4 irq sources in max77705: charger, fuelgauge, usb type-c
> manager ic, and so-called 'topsys'. Hence, max77705 mfd parent device is
> an interrupt controller. This series implements interrupt controller in
> max77705 mfd.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-31 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 22:13 [PATCH] mfd: max77705: rework interrupts Dzmitry Sankouski
2025-08-31 0:02 ` kernel test robot
2025-08-31 8:29 ` Krzysztof Kozlowski [this message]
2025-09-03 12:38 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33eb49c4-aacf-46ec-a7c2-94ec8cba0243@kernel.org \
--to=krzk@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dsankouski@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).