From: Mark Salyzyn <salyzyn@android.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
Tim Murray <timmurray@google.com>,
Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2] firmware_class: make firmware caching configurable
Date: Wed, 13 Nov 2019 16:16:38 -0800 [thread overview]
Message-ID: <33f2baa2-944a-2bfc-1c50-0e437bf11959@android.com> (raw)
In-Reply-To: <20191113231602.GB11244@42.do-not-panic.com>
On 11/13/19 3:16 PM, Luis Chamberlain wrote:
> On Wed, Nov 13, 2019 at 02:54:26PM -0800, Mark Salyzyn wrote:
>> +config FW_CACHE
>> + bool "Enable firmware caching during suspend"
>> + depends on PM_SLEEP
>> + default y if PM_SLEEP
> I think the default y would suffice given you have depends on PM_SLEEP,
> however this also works. So, again:
>
> Acked-by: Luis Chamberlain <mcgrof@kernel.org>
>
> Luis
Worried about setting FW_CACHE w/o PM_SLEEP, this enforces it.
--Mark
next prev parent reply other threads:[~2019-11-14 0:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 21:01 [PATCH] firmware_class: make firmware caching configurable Mark Salyzyn
2019-11-13 21:31 ` Luis Chamberlain
2019-11-13 21:50 ` Greg Kroah-Hartman
2019-11-13 22:13 ` Luis Chamberlain
2019-11-13 22:33 ` Mark Salyzyn
2019-11-13 22:54 ` [PATCH v2] " Mark Salyzyn
2019-11-13 23:16 ` Luis Chamberlain
2019-11-14 0:16 ` Mark Salyzyn [this message]
2019-11-14 0:26 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33f2baa2-944a-2bfc-1c50-0e437bf11959@android.com \
--to=salyzyn@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=timmurray@google.com \
--cc=vnkgutta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox