* [PATCH] dmaengine: usb-dmac: Fix PM usage counter imbalance
@ 2025-07-12 16:51 Zhang Shurong
2025-07-12 18:45 ` Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Shurong @ 2025-07-12 16:51 UTC (permalink / raw)
To: vkoul; +Cc: yanzhen, u.kleine-koenig, dmaengine, linux-kernel, Zhang Shurong
pm_runtime_get_sync will increment pm usage counter
even it failed. Forgetting to putting operation will
result in reference leak here. We fix it by replacing
it with pm_runtime_resume_and_get to keep usage counter
balanced.
Fixes: 0c1c8ff32fa2 ("dmaengine: usb-dmac: Add Renesas USB DMA Controller (USB-DMAC) driver")
Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
---
drivers/dma/sh/usb-dmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
index 7e2b6c97fa2f..6ced61c9feed 100644
--- a/drivers/dma/sh/usb-dmac.c
+++ b/drivers/dma/sh/usb-dmac.c
@@ -393,7 +393,7 @@ static int usb_dmac_alloc_chan_resources(struct dma_chan *chan)
uchan->descs_allocated++;
}
- return pm_runtime_get_sync(chan->device->dev);
+ return pm_runtime_resume_and_get(chan->device->dev);
}
static void usb_dmac_free_chan_resources(struct dma_chan *chan)
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: usb-dmac: Fix PM usage counter imbalance
2025-07-12 16:51 [PATCH] dmaengine: usb-dmac: Fix PM usage counter imbalance Zhang Shurong
@ 2025-07-12 18:45 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2025-07-12 18:45 UTC (permalink / raw)
To: Zhang Shurong, dmaengine
Cc: LKML, Uwe Kleine-König, Vinod Koul, Yan Zhen
…
> result in reference leak here. We fix it by replacing
> it with pm_runtime_resume_and_get to keep usage counter
> balanced.
You may occasionally put more than 55 characters into text lines
of such a change description.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc5#n94
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-12 18:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-12 16:51 [PATCH] dmaengine: usb-dmac: Fix PM usage counter imbalance Zhang Shurong
2025-07-12 18:45 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).