From: Markus Elfring <Markus.Elfring@web.de>
To: Yury Norov <yury.norov@gmail.com>,
kernel-janitors@vger.kernel.org, Ben Segall <bsegall@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Madadi Vineeth Reddy <vineethr@linux.ibm.com>
Subject: Re: [PATCH] sched: fair: drop useless cpumask_empty() in find_energy_efficient_cpu()
Date: Thu, 11 Sep 2025 16:00:35 +0200 [thread overview]
Message-ID: <34069a28-89e2-4881-a8a6-bb9d32c97191@web.de> (raw)
In-Reply-To: <20250911023426.457745-1-yury.norov@gmail.com>
> cpumask_empty() call is O(N) and useless, because the previous
> cpumask_and() returns false for empty 'cpus'.
It seems to be more helpful to reuse a return value from a previous function call.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc5#n94
Regards,
Markus
prev parent reply other threads:[~2025-09-11 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 2:34 [PATCH] sched: fair: drop useless cpumask_empty() in find_energy_efficient_cpu() Yury Norov
2025-09-11 6:44 ` K Prateek Nayak
2025-09-11 6:45 ` Madadi Vineeth Reddy
2025-09-11 8:28 ` Vincent Guittot
2025-09-11 14:00 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34069a28-89e2-4881-a8a6-bb9d32c97191@web.de \
--to=markus.elfring@web.de \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vineethr@linux.ibm.com \
--cc=vschneid@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox