From: Arnd Bergmann <arnd@arndb.de>
To: linaro-acpi@lists.linaro.org
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
rjw@rjwysocki.net, lenb@kernel.org, hdegoede@redhat.com,
tj@kernel.org, mjg59@srcf.ucam.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [Linaro-acpi] [RFC PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching
Date: Thu, 18 Dec 2014 10:17 +0100 [thread overview]
Message-ID: <3408260.hhf4YMy6F6@wuerfel> (raw)
In-Reply-To: <1418858195-22857-3-git-send-email-suravee.suthikulpanit@amd.com>
On Wednesday 17 December 2014 17:16:35 Suravee Suthikulpanit wrote:
> +#ifdef CONFIG_ATA_ACPI
> +#include <linux/acpi.h>
> +#endif
> #include "ahci.h"
>
> static const struct ata_port_info ahci_port_info = {
> @@ -71,6 +74,10 @@ static const struct of_device_id ahci_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, ahci_of_match);
>
> +#ifdef CONFIG_ATA_ACPI
> +static const struct acpi_device_cls ahci_cls = {0x01, 0x06, 0x01};
> +#endif
> +
> static struct platform_driver ahci_driver = {
> .probe = ahci_probe,
> .remove = ata_platform_remove_one,
> @@ -78,6 +85,9 @@ static struct platform_driver ahci_driver = {
> .name = "ahci",
> .owner = THIS_MODULE,
> .of_match_table = ahci_of_match,
> +#ifdef CONFIG_ATA_ACPI
> + .acpi_cls = &ahci_cls,
> +#endif
> .pm = &ahci_pm_ops,
>
It would be better to leave out the various #ifdef here, in particular the
one around the header file inclusion.
Arnd
next prev parent reply other threads:[~2014-12-18 9:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 23:16 [RFC PATCH 0/2] Introduce ACPI support for ahci_platform driver Suravee Suthikulpanit
2014-12-17 23:16 ` [RFC PATCH 1/2] ACPI / scan: Add support for ACPI _CLS device matching Suravee Suthikulpanit
2014-12-19 14:56 ` Hanjun Guo
[not found] ` <549472C6.9090908@amd.com>
2014-12-19 19:33 ` Suravee Suthikulanit
2014-12-17 23:16 ` [RFC PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching Suravee Suthikulpanit
2014-12-18 9:02 ` Hans de Goede
2014-12-18 9:17 ` Arnd Bergmann [this message]
2014-12-19 18:21 ` [Linaro-acpi] " Suravee Suthikulanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3408260.hhf4YMy6F6@wuerfel \
--to=arnd@arndb.de \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@rjwysocki.net \
--cc=suravee.suthikulpanit@amd.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox