From: Can Guo <cang@codeaurora.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] phy: qcom-qmp: Use register defines
Date: Mon, 23 Dec 2019 16:43:27 +0800 [thread overview]
Message-ID: <341446449242684d4b5a0296d3331b0c@codeaurora.org> (raw)
In-Reply-To: <20191220101719.3024693-3-vkoul@kernel.org>
On 2019-12-20 18:17, Vinod Koul wrote:
> We already define register offsets so use them in register layout.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c
> b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 66f91726b8b2..1196c85aa023 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -166,8 +166,8 @@ static const unsigned int
> sdm845_ufsphy_regs_layout[] = {
> };
>
> static const unsigned int sm8150_ufsphy_regs_layout[] = {
> - [QPHY_START_CTRL] = 0x00,
> - [QPHY_PCS_READY_STATUS] = 0x180,
> + [QPHY_START_CTRL] = QPHY_V4_PHY_START,
> + [QPHY_PCS_READY_STATUS] = QPHY_V4_PCS_READY_STATUS,
Missed QPHY_SW_RESET?
Regards,
Can Guo.
> };
>
> static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = {
next prev parent reply other threads:[~2019-12-23 8:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 10:17 [PATCH v2 0/5] phy: qcom-qmp: Fixes and updates for sm8150 Vinod Koul
2019-12-20 10:17 ` [PATCH v2 1/5] phy: qcom-qmp: Increase PHY ready timeout Vinod Koul
2019-12-20 10:17 ` [PATCH v2 2/5] phy: qcom-qmp: Use register defines Vinod Koul
2019-12-23 8:43 ` Can Guo [this message]
2019-12-23 9:07 ` Can Guo
2019-12-20 10:17 ` [PATCH v2 3/5] phy: qcom-qmp: Add optional SW reset Vinod Koul
2019-12-23 9:08 ` Manu Gautam
2019-12-23 14:06 ` Vinod Koul
2019-12-20 10:17 ` [PATCH v2 4/5] phy: qcom-qmp: remove duplicate powerdown write Vinod Koul
2019-12-20 10:17 ` [PATCH v2 5/5] phy: qcom-qmp: remove no_pcs_sw_reset for sm8150 Vinod Koul
2019-12-20 11:29 ` [PATCH v2 0/5] phy: qcom-qmp: Fixes and updates " Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=341446449242684d4b5a0296d3331b0c@codeaurora.org \
--to=cang@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox