From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932212AbcIALDG (ORCPT ); Thu, 1 Sep 2016 07:03:06 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:39471 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbcIALDD (ORCPT ); Thu, 1 Sep 2016 07:03:03 -0400 X-AuditID: cbfee61b-f79466d000001e3c-f3-57c80ae5dec8 From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , Arnd Bergmann , javier@osg.samsung.com, Linus Walleij Subject: Re: [PATCH v2 01/10] pinctrl: dt-bindings: samsung: Add header with values used for configuration Date: Thu, 01 Sep 2016 13:02:57 +0200 Message-id: <3419428.Xfa2aHQ3xc@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1472714638-15676-2-git-send-email-k.kozlowski@samsung.com> References: <1472714638-15676-1-git-send-email-k.kozlowski@samsung.com> <1472714638-15676-2-git-send-email-k.kozlowski@samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsVy+t9jQd2nXCfCDfZME7D4O+kYu8X8I+dY Ld68XcNk8fqFoUX/49fMFufPb2C3mPJnOZPFpsfXWC0u75rDZjHj/D4mi6XXLzJZtO49wm5x +E07q8WqXX8YHfg81sxbw+jx+9ckRo+ds+6ye2xa1cnmcefaHjaPzUvqPbb0A4X6tqxi9Pi8 SS6AM4rLJiU1J7MstUjfLoErY+LO8+wFTYIVS45eYWpg/MXbxcjBISFgInHrb2AXIyeQKSZx 4d56ti5GLg4hgVmMEhMu7mOFcL4ySrQ9mskKUsUmYCUxsX0VI4gtImAocXD3diaQImaBi8wS zSfuMoEkhAVyJD5vfsEMYrMIqEq0TtsPZvMKaEpMvP2KDcQWFfCS6Nn+CGwQp4CHxNTW/+wQ 21oZJY71z4FqEJT4MfkeC4jNLCAvsW//VFYIW0ti/c7jTBMYgQ5FKJuFpGwWkrIFjMyrGCVS C5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYIj65n0DsbDu9wPMQpwMCrx8M6wPB4uxJpYVlyZ e4hRgoNZSYT3DuuJcCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8j/+vCxMSSE8sSc1OTS1ILYLJ MnFwSjUwikw8pjz95rQ1z507zJ8m2Veem7ZPVyzwWs1Fx/d5CbOVLHasrzY8Nom/+mTDvJMl KquYmR2XsG76diUhyDZkv/mMXDMX9bd6AovYCjz4vc7FyasFi+as2HC8KW3tp3o5ReUFxlPX SK35MNFIXyYvp25569KbUu+kquP/PDvgOkOt8MShYx39SizFGYmGWsxFxYkAzT5U5KgCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday, September 01, 2016 09:23:49 AM Krzysztof Kozlowski wrote: > Hard-coded pinctrl configuration values are scattered through DTS files. > The numbers are difficult to decode by human, especially without the > datasheet. Additionally the drive strength differs between Exynos SoC > families increasing the confusion. > > The header will help making this more readable and maintainable. > > Signed-off-by: Krzysztof Kozlowski > --- > MAINTAINERS | 1 + > include/dt-bindings/pinctrl/samsung.h | 57 +++++++++++++++++++++++++++++++++++ > 2 files changed, 58 insertions(+) > create mode 100644 include/dt-bindings/pinctrl/samsung.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index d8e81b1dde30..836bcd327ee4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9318,6 +9318,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > L: linux-samsung-soc@vger.kernel.org (moderated for non-subscribers) > S: Maintained > F: drivers/pinctrl/samsung/ > +F: include/dt-bindings/pinctrl/samsung.h > > PIN CONTROLLER - SINGLE > M: Tony Lindgren > diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h > new file mode 100644 > index 000000000000..0f410ba5ec7e > --- /dev/null > +++ b/include/dt-bindings/pinctrl/samsung.h > @@ -0,0 +1,57 @@ > +/* > + * Samsung's Exynos pinctrl bindings > + * > + * Copyright (c) 2016 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * Author: Krzysztof Kozlowski > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > +*/ > + > +#ifndef __DT_BINDINGS_PINCTRL_EXYNOS_H__ > +#define __DT_BINDINGS_PINCTRL_EXYNOS_H__ Minor nit: shouldn't this be __DT_BINDINGS_PINCTRL_SAMSUNG_H__ (the header file is named samsung.h and is going to be used also by s3c* SoCs)? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics