From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753022AbcJJOPz (ORCPT <rfc822;w@1wt.eu>);
        Mon, 10 Oct 2016 10:15:55 -0400
Received: from mout.kundenserver.de ([212.227.126.135]:50781 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752375AbcJJOPw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Oct 2016 10:15:52 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Yangbo Lu <yangbo.lu@nxp.com>, Lee Jones <lee.jones@linaro.org>,
        Dirk Behme <dirk.behme@de.bosch.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] base: soc: Early register bus when needed
Date: Mon, 10 Oct 2016 16:15:05 +0200
Message-ID: <3420819.lDRyD1Xpvb@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1475572167-29581-2-git-send-email-geert+renesas@glider.be>
References: <1475572167-29581-1-git-send-email-geert+renesas@glider.be> <1475572167-29581-2-git-send-email-geert+renesas@glider.be>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:JdKIv14GyBWS6/ZZSt1NClgS/xXv8vCn+lpZ+IAmPamfsBd+OoC
 tbORQXKvnMKZQJ8U4ya4S9DnMDbIjgWW3jyfhXpebjclQAnhibAobCmdkBiuhAvveDHc3oh
 fbfaaxZZ4qbt39RgqDQwRx5no+LOlyaaHdnyv6cuiSnHoVWgNt/x1sR9/R6ryQMfqswN5Is
 5TI35Sd2RajKIwuaQSoZA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:vuoPliRc/ss=:91MihweJA/J9OKbSOrMAYK
 3WVMJBS/39YIQXh5g7F3LYKKOP5G7MYsvfL5qOqXPiCGplODX6naQrGuOuoUqF7bNp5XPqGA8
 h/rHaMpRmwnzZGRFMbKrpVnCYF5Oc139LT2aUDF3jC2SRxonoa3hf4wWl1yCY7/Dh5n/WdZOn
 NmhOpsByr6jNgMtfLhKAS/sitXRmbdkGg7zJZ4Kf5BlGvJOm67ssO1OrKtsHp0OzD9ms8nfaB
 XL16FlJXXmBaRffzG6OKmI2AEWCUezjAcf6A3SQGVTXMNSnXLFFDvoMtq/4wuD0idrW0KYXWT
 UlePTtJ9346NKOiGYTgAPaLJwsuoq9ncq4I8VqSNjcHYCX1mqNkDmz2Pic68/C9AHgIi/gUm9
 xeyLbDIlUClDAlpupiademcHeHcaGbhkaRdtTYsBPwa/agCT+QLi12zKS6wBuN2mRDoyXPli3
 prs7mRAp1Wl57g6Wb3Zys9zApbqlcUCQQkM1gvrD3XmxYI/LXKoFOKCAWixWFhr7MT4P9PsYH
 ANnQNMSAoLBhxy/TGzzr2JcHH8K3M34gJILhokV5UCWKPoPkbg22InPRWgtrn9B83OMKS5lAg
 kEtCFA92d74iHxlPJgkiWS3xB6WZUWUFmKOArYA5L7tF++0AVe17zrfqcjKVR9WkiAv5KoRMn
 uptlAlIbTcisdRB3oANhILHAYBUMceipy7A552n3uk/dx4EXMf1BpzHkqYLMCyTauP/9Dk6SM
 j+KX1dxq1aNHpahv
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, October 4, 2016 11:09:24 AM CEST Geert Uytterhoeven wrote:
> If soc_device_register() is called before soc_bus_register(), it crashes
> with a NULL pointer dereference.
> 
> soc_bus_register() is already a core_initcall(), but drivers/base/ is
> entered later than e.g. drivers/pinctrl/ and drivers/soc/. Hence there
> are several subsystems that may need to know SoC revision information,
> while it's not so easy to initialize the SoC bus even earlier using an
> initcall.
> 
> To fix this, let soc_device_register() register the bus early if that
> hasn't happened yet.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 

Not nice, but I can't think of a better alternative, so

Acked-by: Arnd Bergmann <arnd@arndb.de>