From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752489AbdIARUi (ORCPT ); Fri, 1 Sep 2017 13:20:38 -0400 Received: from gloria.sntech.de ([95.129.55.99]:42888 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbdIARUh (ORCPT ); Fri, 1 Sep 2017 13:20:37 -0400 From: Heiko Stuebner To: Jagan Teki Cc: Rob Herring , "linux-arm-kernel@lists.infradead.org" , Mark Rutland , Russell King , Michael Trimarchi , linux-rockchip@lists.infradead.org, "linux-kernel@vger.kernel.org" , devicetree , Jagan Teki Subject: Re: [PATCH v2 2/2] ARM: dts: rockchip: Add rk3288 vyasa board Date: Fri, 01 Sep 2017 19:20:28 +0200 Message-ID: <3424135.KE5FrDYz9C@phil> User-Agent: KMail/5.2.3 (Linux/4.11.0-1-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: References: <1503742164-3926-1-git-send-email-jteki@openedev.com> <20170831210421.l2zmpexisagoxdks@rob-hp-laptop> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 1. September 2017, 22:36:08 CEST schrieb Jagan Teki: > On Fri, Sep 1, 2017 at 2:34 AM, Rob Herring wrote: > > On Sat, Aug 26, 2017 at 03:39:24PM +0530, Jagan Teki wrote: > >> From: Jagan Teki > >> > >> This patch adds initial support for rk3288 based > >> Vyasa board, which is made by Amarula Solutions. > >> > >> Signed-off-by: Jagan Teki > >> --- > >> Changes for v2: > >> - Added entry in Documentation/devicetree/bindings/arm/rockchip.txt > >> > >> Documentation/devicetree/bindings/arm/rockchip.txt | 4 + > >> arch/arm/boot/dts/Makefile | 3 +- > >> arch/arm/boot/dts/rk3288-vyasa.dts | 312 +++++++++++++++++++++ > >> 3 files changed, 318 insertions(+), 1 deletion(-) > >> create mode 100644 arch/arm/boot/dts/rk3288-vyasa.dts > > > > Acked-by: Rob Herring > > > > I assume the regulator node names are consistent with other platforms, > > but at some point please fix them to be lowercase and not use '_'. IOW, > > build the dtbs with "W=2" and fix the warnings. > > Out-off these [1], only /i2c@ff650000 and /memory are related to this > dts and these are consistent across rk3288 dts node name, so there is > nothing that I can fix here. If not please let me know if you find > any. And the regulator node-names are actually part of the rk808 binding, so should also stay that way. Heiko