* [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function
@ 2022-09-20 12:22 Tommaso Merciai
2022-09-20 12:23 ` Christian König
0 siblings, 1 reply; 4+ messages in thread
From: Tommaso Merciai @ 2022-09-20 12:22 UTC (permalink / raw)
To: tommaso.merciai
Cc: linuxfancy, linux-amarula, sudipm.mukherjee, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Nathan Chancellor, Nick Desaulniers, Tom Rix, Andrey Grodzovsky,
Luben Tuikov, Philip Yang, amd-gfx, dri-devel, linux-kernel, llvm
The builds of arm64 allmodconfig with clang failed to build
next-20220920 with the following result:
1190:3: error: variable 'r' is uninitialized when used here [-Werror,-Wuninitialized]
note: initialize the variable 'r' to silence this warning
This fix compilation error
Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index 58088c663125..efa3dc9b69fd 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
@@ -1168,7 +1168,7 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
struct amdgpu_bo_list_entry *e;
struct amdgpu_job *job;
uint64_t seq;
- int r;
+ int r = 0;
job = p->job;
p->job = NULL;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function
2022-09-20 12:22 [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function Tommaso Merciai
@ 2022-09-20 12:23 ` Christian König
2022-09-20 12:32 ` Tommaso Merciai
0 siblings, 1 reply; 4+ messages in thread
From: Christian König @ 2022-09-20 12:23 UTC (permalink / raw)
To: Tommaso Merciai
Cc: linuxfancy, linux-amarula, sudipm.mukherjee, Alex Deucher,
Pan, Xinhui, David Airlie, Daniel Vetter, Nathan Chancellor,
Nick Desaulniers, Tom Rix, Andrey Grodzovsky, Luben Tuikov,
Philip Yang, amd-gfx, dri-devel, linux-kernel, llvm
Am 20.09.22 um 14:22 schrieb Tommaso Merciai:
> The builds of arm64 allmodconfig with clang failed to build
> next-20220920 with the following result:
>
> 1190:3: error: variable 'r' is uninitialized when used here [-Werror,-Wuninitialized]
> note: initialize the variable 'r' to silence this warning
>
> This fix compilation error
I've already send a patch to fix this to the mailing list 7 Minutes ago :)
Please review or ack that one.
Thanks,
Christian.
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 58088c663125..efa3dc9b69fd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -1168,7 +1168,7 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
> struct amdgpu_bo_list_entry *e;
> struct amdgpu_job *job;
> uint64_t seq;
> - int r;
> + int r = 0;
>
> job = p->job;
> p->job = NULL;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function
2022-09-20 12:23 ` Christian König
@ 2022-09-20 12:32 ` Tommaso Merciai
2022-09-20 12:57 ` Christian König
0 siblings, 1 reply; 4+ messages in thread
From: Tommaso Merciai @ 2022-09-20 12:32 UTC (permalink / raw)
To: Christian König
Cc: linuxfancy, linux-amarula, sudipm.mukherjee, Alex Deucher,
Pan, Xinhui, David Airlie, Daniel Vetter, Nathan Chancellor,
Nick Desaulniers, Tom Rix, Andrey Grodzovsky, Luben Tuikov,
Philip Yang, amd-gfx, dri-devel, linux-kernel, llvm
Hi Christian,
On Tue, Sep 20, 2022 at 02:23:58PM +0200, Christian König wrote:
> Am 20.09.22 um 14:22 schrieb Tommaso Merciai:
> > The builds of arm64 allmodconfig with clang failed to build
> > next-20220920 with the following result:
> >
> > 1190:3: error: variable 'r' is uninitialized when used here [-Werror,-Wuninitialized]
> > note: initialize the variable 'r' to silence this warning
> >
> > This fix compilation error
>
> I've already send a patch to fix this to the mailing list 7 Minutes ago :)
>
> Please review or ack that one.
Sorry, my bad. Don't see your patch :)
Cheers,
Tommaso
>
> Thanks,
> Christian.
>
> >
> > Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> > index 58088c663125..efa3dc9b69fd 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> > @@ -1168,7 +1168,7 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
> > struct amdgpu_bo_list_entry *e;
> > struct amdgpu_job *job;
> > uint64_t seq;
> > - int r;
> > + int r = 0;
> > job = p->job;
> > p->job = NULL;
>
--
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function
2022-09-20 12:32 ` Tommaso Merciai
@ 2022-09-20 12:57 ` Christian König
0 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2022-09-20 12:57 UTC (permalink / raw)
To: Tommaso Merciai, Christian König
Cc: Andrey Grodzovsky, llvm, Philip Yang, David Airlie, linuxfancy,
Pan, Xinhui, Nick Desaulniers, linux-kernel, amd-gfx,
Nathan Chancellor, Luben Tuikov, dri-devel, Daniel Vetter,
Tom Rix, Alex Deucher, linux-amarula, sudipm.mukherjee
Am 20.09.22 um 14:32 schrieb Tommaso Merciai:
> Hi Christian,
>
> On Tue, Sep 20, 2022 at 02:23:58PM +0200, Christian König wrote:
>> Am 20.09.22 um 14:22 schrieb Tommaso Merciai:
>>> The builds of arm64 allmodconfig with clang failed to build
>>> next-20220920 with the following result:
>>>
>>> 1190:3: error: variable 'r' is uninitialized when used here [-Werror,-Wuninitialized]
>>> note: initialize the variable 'r' to silence this warning
>>>
>>> This fix compilation error
>> I've already send a patch to fix this to the mailing list 7 Minutes ago :)
>>
>> Please review or ack that one.
> Sorry, my bad. Don't see your patch :)
No problem, already reviewed and pushed :)
It probably takes a moment for the mailing list to deliver the patch to
everybody.
Cheers,
Christian.
>
> Cheers,
> Tommaso
>
>> Thanks,
>> Christian.
>>
>>> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
>>> index 58088c663125..efa3dc9b69fd 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
>>> @@ -1168,7 +1168,7 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
>>> struct amdgpu_bo_list_entry *e;
>>> struct amdgpu_job *job;
>>> uint64_t seq;
>>> - int r;
>>> + int r = 0;
>>> job = p->job;
>>> p->job = NULL;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-20 12:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-20 12:22 [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function Tommaso Merciai
2022-09-20 12:23 ` Christian König
2022-09-20 12:32 ` Tommaso Merciai
2022-09-20 12:57 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox