From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Khadija Kamran <kamrankhadijadj@gmail.com>,
Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
paskripkin@gmail.com, gregkh@linuxfoundation.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] Staging: r8188eu: Fixed block comment
Date: Fri, 10 Mar 2023 13:25:50 +0100 [thread overview]
Message-ID: <3436236.som1txNFv6@suse> (raw)
In-Reply-To: <bb4e7ac8-5ddf-46c7-8c5a-08839794c5d0@kili.mountain>
On venerdì 10 marzo 2023 13:09:54 CET Dan Carpenter wrote:
> On Fri, Mar 10, 2023 at 12:52:55PM +0100, Fabio M. De Francesco wrote:
> > On venerdì 17 febbraio 2023 08:17:00 CET Khadija Kamran wrote:
> > > Fixed block comment by adding '*' in each line. The Check message was
> > > shown by using checkpatch.pl script.
> > >
> > > Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> > > ---
> > >
> > > drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
> > > 1 file changed, 10 insertions(+), 9 deletions(-)
> >
> > Hi Khadija,
> >
> > As Greg said this driver is not here any longer. This makes me think that
> > you
> > forgot at least two things...
> >
> > 1) Please pull and rebase the staging tree every day while working on
> > patches
> > during this period of the Outreachy project. If you had done so, you would
> > have noticed that your patch cannot any more be applied.
>
> This patch was sent long before the driver was deleted... The patch was
> fine and would have been applied if the driver hadn't been removed.
>
> regards,
> dan carpenter
I'm sorry I did not look at the day of the submission.
I took for granted that this patch had been sent after the contribution period
start date, March 6th 2023.
Thanks Dan for making me notice this mistake.
Regards,
Fabio
prev parent reply other threads:[~2023-03-10 12:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 7:17 [PATCH] Staging: r8188eu: Fixed block comment Khadija Kamran
2023-02-18 19:11 ` Philipp Hortmann
2023-03-09 9:10 ` Greg KH
2023-03-10 11:52 ` Fabio M. De Francesco
2023-03-10 12:09 ` Dan Carpenter
2023-03-10 12:25 ` Fabio M. De Francesco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3436236.som1txNFv6@suse \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kamrankhadijadj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox