* [PATCH] spi/rockchip: fixup incorrect dma direction setting
@ 2014-08-20 3:47 Addy Ke
2014-08-20 8:09 ` Heiko Stübner
2014-08-20 15:31 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Addy Ke @ 2014-08-20 3:47 UTC (permalink / raw)
To: broonie, heiko, dianders, grant.likely, robh+dt
Cc: linux-kernel, linux-spi, linux-arm-kernel, devicetree, olof, hj,
kever.yang, xjq, huangtao, zyw, yzq, zhenfu.fang, cf, zhangqing,
hl, wei.luo, Addy Ke
Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
---
drivers/spi/spi-rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index cb8fd6f..4ef3fd3 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -679,7 +679,7 @@ static int rockchip_spi_probe(struct platform_device *pdev)
rs->dma_tx.addr = (dma_addr_t)(mem->start + ROCKCHIP_SPI_TXDR);
rs->dma_rx.addr = (dma_addr_t)(mem->start + ROCKCHIP_SPI_RXDR);
rs->dma_tx.direction = DMA_MEM_TO_DEV;
- rs->dma_tx.direction = DMA_DEV_TO_MEM;
+ rs->dma_rx.direction = DMA_DEV_TO_MEM;
master->can_dma = rockchip_spi_can_dma;
master->dma_tx = rs->dma_tx.ch;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] spi/rockchip: fixup incorrect dma direction setting
2014-08-20 3:47 [PATCH] spi/rockchip: fixup incorrect dma direction setting Addy Ke
@ 2014-08-20 8:09 ` Heiko Stübner
2014-08-20 15:31 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2014-08-20 8:09 UTC (permalink / raw)
To: Addy Ke
Cc: broonie, dianders, grant.likely, robh+dt, linux-kernel, linux-spi,
linux-arm-kernel, devicetree, olof, hj, kever.yang, xjq, huangtao,
zyw, yzq, zhenfu.fang, cf, zhangqing, hl, wei.luo
Hi Addy,
please always remember to add a real commit message, something similar to:
"Fix typo that caused the tx direction to be set twice and left out the rx
direction."
for example.
> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
> ---
> drivers/spi/spi-rockchip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
> index cb8fd6f..4ef3fd3 100644
> --- a/drivers/spi/spi-rockchip.c
> +++ b/drivers/spi/spi-rockchip.c
> @@ -679,7 +679,7 @@ static int rockchip_spi_probe(struct platform_device
> *pdev) rs->dma_tx.addr = (dma_addr_t)(mem->start + ROCKCHIP_SPI_TXDR);
> rs->dma_rx.addr = (dma_addr_t)(mem->start + ROCKCHIP_SPI_RXDR);
> rs->dma_tx.direction = DMA_MEM_TO_DEV;
> - rs->dma_tx.direction = DMA_DEV_TO_MEM;
> + rs->dma_rx.direction = DMA_DEV_TO_MEM;
>
> master->can_dma = rockchip_spi_can_dma;
> master->dma_tx = rs->dma_tx.ch;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi/rockchip: fixup incorrect dma direction setting
2014-08-20 3:47 [PATCH] spi/rockchip: fixup incorrect dma direction setting Addy Ke
2014-08-20 8:09 ` Heiko Stübner
@ 2014-08-20 15:31 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-08-20 15:31 UTC (permalink / raw)
To: Addy Ke
Cc: heiko, dianders, grant.likely, robh+dt, linux-kernel, linux-spi,
linux-arm-kernel, devicetree, olof, hj, kever.yang, xjq, huangtao,
zyw, yzq, zhenfu.fang, cf, zhangqing, hl, wei.luo
[-- Attachment #1: Type: text/plain, Size: 125 bytes --]
On Wed, Aug 20, 2014 at 11:47:42AM +0800, Addy Ke wrote:
> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-20 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-20 3:47 [PATCH] spi/rockchip: fixup incorrect dma direction setting Addy Ke
2014-08-20 8:09 ` Heiko Stübner
2014-08-20 15:31 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox