From: Arnd Bergmann <arnd@arndb.de>
To: David Brown <davidb@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org,
Randy Dunlap <rdunlap@xenotime.net>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
Alan Cox <alan@linux.intel.com>,
Grant Likely <grant.likely@secretlab.ca>,
linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/4] msm_serial: Add devicetree support
Date: Tue, 16 Aug 2011 21:07:08 +0200 [thread overview]
Message-ID: <3445697.36l0oAAgCs@wuerfel> (raw)
In-Reply-To: <20110816175702.GA27576@huya.qualcomm.com>
On Tuesday 16 August 2011 10:57:02 David Brown wrote:
> How about if I just keep it simple for now. Since there isn't
> actually a driver for the DMA version, this driver will handle both
> UART blocks, so I'll just do the plain thing in the DT.
Sounds good to me.
> In the future, when a DMA-capable driver exists, we can figure out how
> to determine which driver should be used. At this point, I'm not even
> sure what the correct answer will be, since a given configuration may
> want to use non-DMA for one msm-hsuart device, and the DMA driver for
> another. It's kind of board/use specific, but beyond just describing
> what the hardware is.
In order to be absolutely future-proof, you could mandate that you always
list two "compatible" values, one for the generic version and one for
the specific implementation (high-speed or low-speed). It's a simple
change from what you have now and it allows to change the drivers to
bind to just the specific name in case you want to handle them separately
in the future, without having to change the device tree files.
Arnd
next prev parent reply other threads:[~2011-08-16 19:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 23:00 [PATCH 0/4] Initial DT support for MSM8660 David Brown
2011-08-12 23:00 ` [PATCH 1/4] msm_serial: Use relative resources for iomem David Brown
2011-08-12 23:00 ` [PATCH 2/4] msm_serial: Add devicetree support David Brown
2011-08-13 8:29 ` Arnd Bergmann
2011-08-13 19:46 ` David Brown
2011-08-13 21:34 ` Arnd Bergmann
2011-08-16 17:57 ` David Brown
2011-08-16 19:07 ` Arnd Bergmann [this message]
2011-08-12 23:00 ` [PATCH 3/4] ARM: msm: Add devicetree support for msm8660-surf David Brown
2011-08-12 23:00 ` [PATCH 4/4] ARM: msm: Describe MSM 8660 SURF FPGA registers in DT David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3445697.36l0oAAgCs@wuerfel \
--to=arnd@arndb.de \
--cc=alan@linux.intel.com \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwalker@fifo99.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox