From: David Laight <David.Laight@ACULAB.COM>
To: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'Andy Shevchenko'" <andriy.shevchenko@linux.intel.com>,
'Andrew Morton' <akpm@linux-foundation.org>,
"'Matthew Wilcox (Oracle)'" <willy@infradead.org>,
'Christoph Hellwig' <hch@infradead.org>,
"'Jason A. Donenfeld'" <Jason@zx2c4.com>
Subject: [PATCH next v2 4/5] minmax: Allow comparisons of 'int' against 'unsigned char/short'.
Date: Fri, 28 Jul 2023 14:52:49 +0000 [thread overview]
Message-ID: <34492660a17e44c19a98c4f0f37f6320@AcuMS.aculab.com> (raw)
In-Reply-To: <bde3d2dc933848bbaceeb9b7102f6f4c@AcuMS.aculab.com>
Since 'unsigned char/short' get promoted to 'signed int' it is
safe to compare them against an 'int' value.
Signed-off-by: David Laight <david.laight@aculab.com>
---
v2: No change
include/linux/minmax.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/minmax.h b/include/linux/minmax.h
index 4c77ac9ed284..7d3ad9cbbff6 100644
--- a/include/linux/minmax.h
+++ b/include/linux/minmax.h
@@ -20,7 +20,8 @@
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
#define __types_ok(x, y) \
- (is_signed_type(typeof(x)) == is_signed_type(typeof(y)))
+ (is_signed_type(typeof(x)) == is_signed_type(typeof(y)) || \
+ is_signed_type(typeof((x) + 0)) == is_signed_type(typeof((y) + 0)))
#define __cmp_op_min <
#define __cmp_op_max >
--
2.17.1
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-07-28 14:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 14:49 [PATCH next v2 0/5] minmax: Relax type checks in min() and max() David Laight
2023-07-28 14:50 ` [PATCH next v2 1/5] minmax: Add min_unsigned(a, b) and max_unsigned(a, b) David Laight
2023-07-28 14:51 ` [PATCH next v2 2/5] minmax: Allow min()/max()/clamp() if the arguments have the same signedness David Laight
2023-07-29 2:00 ` kernel test robot
2023-07-30 14:55 ` David Laight
2023-07-30 17:05 ` Nathan Chancellor
2023-07-30 17:33 ` David Laight
2023-07-31 21:43 ` kernel test robot
2023-08-01 8:45 ` David Laight
2023-07-28 14:52 ` [PATCH next v2 3/5] minmax: Fix indentation of __cmp_once() and __clamp_once() David Laight
2023-07-28 14:52 ` David Laight [this message]
2023-07-28 14:53 ` [PATCH next v2 5/5] minmax: Relax check to allow comparison between int and small unsigned constants David Laight
2023-07-28 21:43 ` kernel test robot
2023-07-30 16:55 ` David Laight
2023-07-31 13:26 ` David Laight
2023-08-01 16:02 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34492660a17e44c19a98c4f0f37f6320@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox