From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAC8F38E8D2 for ; Wed, 13 May 2026 17:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778691656; cv=none; b=qKGNwYetIENJy7D+PgR/zP5l8EjJJjIpCxncNsp3KiJL0XWN3CFlKG1Knku5WcvNerVRAa0OLOxhlRLV9puft1hIyQYZwbE9vosJ8m46olpnxvxWyjQGHPgBLH8xTZFFb6fqhTWiNqw/A2Qtv2tkE1QlotZS114bCEJtNt3iVqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778691656; c=relaxed/simple; bh=0PgoVkbIJH9N2NoH6XkGPw5C/TAeZ3Yv9+lY6pYTSFQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WToMrolFt+gseplJewSz2dBFwQiHK3kBvaKTJ5YS9UEKmkDqDBOactO6BdajYaJWblG2vT8MMVw/l/STwsWWn9jI/9QSWy4UYd5EpRWPHsz1y9CqLw6yYp/3BjnPg+8FL9suKdDlF9ibWW/YjttnrVDaC96fKjU6tkSe20tm5Nw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S6cCxd+S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S6cCxd+S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87BA9C2BCB7; Wed, 13 May 2026 17:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778691656; bh=0PgoVkbIJH9N2NoH6XkGPw5C/TAeZ3Yv9+lY6pYTSFQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S6cCxd+SxxusCjiRuyArac5qlK/iNc5LrpHJJ7i3t0muizcOZy7bg4MnhRpPUvFCx VzzXoI2Nyuv9WEHzb0tR5VeAaHfnyEgGY4VQI9jUpBch9cEOk8qgBbExafU+EuclzQ GLn0EYb12XUZAp7s5E+lmJhc9CsFwZXc2oVaxXJEaWuznYP7KZ6/OenrO1owA/X0B1 eh1M7fK3+iitM41MQMuXq9KmhYS7Q2mYwKyKwd/r4VCUKYKBSEuE3vT3t4Z9gKOdxD BGz/xV/6hjQewzIQ8MWBty1RwjOwQUcx7vyDRwLju4vMD1CMdiae+WpigXbjTEAs8/ xI3mqGLcJkdEw== Message-ID: <3453825f-2bc0-4d63-8731-3eaf9fc716a4@kernel.org> Date: Wed, 13 May 2026 19:00:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 20/22] mm/page_alloc: implement __GFP_UNMAPPED|__GFP_ZERO allocations Content-Language: en-US To: Brendan Jackman , Borislav Petkov , Dave Hansen , Peter Zijlstra , Andrew Morton , David Hildenbrand , Wei Xu , Johannes Weiner , Zi Yan , Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, rppt@kernel.org, Sumit Garg , derkling@google.com, reijiw@google.com, Will Deacon , rientjes@google.com, patrick.roy@linux.dev, "Itazuri, Takahiro" , Andy Lutomirski , David Kaplan , Thomas Gleixner , Yosry Ahmed References: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com> <20260320-page_alloc-unmapped-v2-20-28bf1bd54f41@google.com> From: "Vlastimil Babka (SUSE)" In-Reply-To: <20260320-page_alloc-unmapped-v2-20-28bf1bd54f41@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/20/26 19:23, Brendan Jackman wrote: > The pages being zeroed here are unmapped, so they can't be zeroed via > the direct map. Temporarily mapping them in the direct map is not > possible because: > > - In general this requires allocating pagetables, > > - Unmapping them would require a TLB shootdown, which can't be done in > general from the allocator (x86 requires IRQs on). > > Therefore, use the new mermap mechanism to zero these pages. > > The main mermap API is expected to fail very often. In order to avoid > needing to fail allocations when that happens, instead fallback to the > special mermap_get_reserved() variant, which is less efficient. > > Signed-off-by: Brendan Jackman > --- > arch/x86/include/asm/pgtable_types.h | 2 + > mm/Kconfig | 11 +++++- > mm/page_alloc.c | 76 +++++++++++++++++++++++++++++++----- > 3 files changed, 78 insertions(+), 11 deletions(-) > > diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h > index 2ec250ba467e2..c3d73bdfff1fa 100644 > --- a/arch/x86/include/asm/pgtable_types.h > +++ b/arch/x86/include/asm/pgtable_types.h > @@ -223,6 +223,7 @@ enum page_cache_mode { > #define __PAGE_KERNEL_RO (__PP| 0| 0|___A|__NX| 0| 0|___G) > #define __PAGE_KERNEL_ROX (__PP| 0| 0|___A| 0| 0| 0|___G) > #define __PAGE_KERNEL (__PP|__RW| 0|___A|__NX|___D| 0|___G) > +#define __PAGE_KERNEL_NOGLOBAL (__PP|__RW| 0|___A|__NX|___D| 0| 0) > #define __PAGE_KERNEL_EXEC (__PP|__RW| 0|___A| 0|___D| 0|___G) > #define __PAGE_KERNEL_NOCACHE (__PP|__RW| 0|___A|__NX|___D| 0|___G| __NC) > #define __PAGE_KERNEL_VVAR (__PP| 0|_USR|___A|__NX| 0| 0|___G) > @@ -245,6 +246,7 @@ enum page_cache_mode { > #define __pgprot_mask(x) __pgprot((x) & __default_kernel_pte_mask) > > #define PAGE_KERNEL __pgprot_mask(__PAGE_KERNEL | _ENC) > +#define PAGE_KERNEL_NOGLOBAL __pgprot_mask(__PAGE_KERNEL_NOGLOBAL | _ENC) > #define PAGE_KERNEL_NOENC __pgprot_mask(__PAGE_KERNEL | 0) > #define PAGE_KERNEL_RO __pgprot_mask(__PAGE_KERNEL_RO | _ENC) > #define PAGE_KERNEL_EXEC __pgprot_mask(__PAGE_KERNEL_EXEC | _ENC) Should this be part of earlier mermap x86 patches? > diff --git a/mm/Kconfig b/mm/Kconfig > index e4cb52149acad..05b2bb841d0e0 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1506,7 +1506,14 @@ config MERMAP_KUNIT_TEST > If unsure, say N. > > config PAGE_ALLOC_UNMAPPED > - bool "Support allocating pages that aren't in the direct map" if COMPILE_TEST > - default COMPILE_TEST > + bool "Support allocating pages that aren't in the direct map" > + depends on MERMAP > + > +config PAGE_ALLOC_KUNIT_TESTS > + tristate "KUnit tests for the page allocator" if !KUNIT_ALL_TESTS > + depends on KUNIT > + default KUNIT_ALL_TESTS > + help > + Builds KUnit tests for the page allocator. This belongs to the next patch? > endmenu > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 710ee9f46d467..7c91dcbe32576 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -14,6 +14,7 @@ > * (lots of bits borrowed from Ingo Molnar & Andrew Morton) > */ > > +#include > #include > #include > #include > @@ -1327,15 +1328,72 @@ static inline bool should_skip_kasan_poison(struct page *page) > return page_kasan_tag(page) == KASAN_TAG_KERNEL; > } > > -static void kernel_init_pages(struct page *page, int numpages) > +#ifdef CONFIG_PAGE_ALLOC_UNMAPPED > +static inline bool pageblock_unmapped(struct page *page) > { > - int i; > + return freetype_flags(get_pageblock_freetype(page)) & FREETYPE_UNMAPPED; > +} > > - /* s390's use of memset() could override KASAN redzones. */ > - kasan_disable_current(); > - for (i = 0; i < numpages; i++) > - clear_highpage_kasan_tagged(page + i); > - kasan_enable_current(); > +static inline void clear_page_mermap(struct page *page, unsigned int numpages) > +{ > + void *mermap; > + > + BUILD_BUG_ON(IS_ENABLED(CONFIG_HIGHMEM)); > + > + /* Fast path: single mapping (may fail under preemption). */ > + mermap = mermap_get(page, numpages << PAGE_SHIFT, PAGE_KERNEL_NOGLOBAL); > + if (mermap) { > + void *buf = kasan_reset_tag(mermap_addr(mermap)); > + > + for (int i = 0; i < numpages; i++) > + clear_page(buf + (i << PAGE_SHIFT)); > + mermap_put(mermap); > + return; > + } > + > + /* Slow path, map each page individually (always succeeds). */ > + for (int i = 0; i < numpages; i++) { > + unsigned long flags; > + > + local_irq_save(flags); > + mermap = mermap_get_reserved(page + i, PAGE_KERNEL_NOGLOBAL); > + clear_page(kasan_reset_tag(mermap_addr(mermap))); > + mermap_put(mermap); > + local_irq_restore(flags); > + } > +} > +#else > +static inline bool pageblock_unmapped(struct page *page) > +{ > + return false; > +} > + > +static inline void clear_page_mermap(struct page *page, unsigned int numpages) > +{ > + BUG(); > +} > +#endif > + > +static void kernel_init_pages(struct page *page, unsigned int numpages) > +{ > + int num_blocks = DIV_ROUND_UP(numpages, pageblock_nr_pages); > + > + for (int block = 0; block < num_blocks; block++) { > + struct page *block_page = page + (block << pageblock_order); > + bool unmapped = pageblock_unmapped(block_page); > + > + /* s390's use of memset() could override KASAN redzones. */ > + kasan_disable_current(); > + if (unmapped) { > + clear_page_mermap(block_page, numpages); > + } else { > + for (int i = 0; i < min(numpages, pageblock_nr_pages); i++) > + clear_highpage_kasan_tagged(block_page + i); > + } > + kasan_enable_current(); > + > + numpages -= pageblock_nr_pages; > + } > } > > #ifdef CONFIG_MEM_ALLOC_PROFILING > @@ -5250,8 +5308,8 @@ static inline bool prepare_alloc_pages(gfp_t gfp_mask, unsigned int order, > ac->nodemask = nodemask; > ac->freetype = gfp_freetype(gfp_mask); > > - /* Not implemented yet. */ > - if (freetype_flags(ac->freetype) & FREETYPE_UNMAPPED && gfp_mask & __GFP_ZERO) > + if (freetype_flags(ac->freetype) & FREETYPE_UNMAPPED && > + WARN_ON(!mermap_ready())) > return false; > > if (cpusets_enabled()) { >