From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81757C433F5 for ; Tue, 26 Apr 2022 07:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344280AbiDZIBs (ORCPT ); Tue, 26 Apr 2022 04:01:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343898AbiDZIBp (ORCPT ); Tue, 26 Apr 2022 04:01:45 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8513B27B35; Tue, 26 Apr 2022 00:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650959918; x=1682495918; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=wVKkLqJ+ha6OQUETVJ5tS6AU8CVJK7lT5PD+0UFZHn8=; b=WfBy3khhIgyCwkNjVMwF1g4mH9GpFBGT5QSOWYpyfyQeJT0WqKyacY8K knOZr0WS5pvV5VpWFpAIM6XETojJtrv2/SPoi9OgDZ8uKWVPNa5n8v4IF aNHdsbIaUAasoH2wB7+ZRuIjPfUKoFSq4IVxnj4KnOK6+WKIMQA86xVce S97MkL+IQCqgYVd/Z98/iCN+lcYtKkBcaUpahOpe/7iWvcyy6VoR8xmpo dfIa8jf2FMdQsgD5zbgRx1QyMDHFhqER9NKSN31V8qX+tPxT8YTOa2cGf 5Tg4NTE7xVKWxwqv9mbo3xBSlVUF8ZllXmujyfTZz0z4R1AqlALO+Oufc A==; X-IronPort-AV: E=McAfee;i="6400,9594,10328"; a="265656023" X-IronPort-AV: E=Sophos;i="5.90,290,1643702400"; d="scan'208";a="265656023" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 00:58:38 -0700 X-IronPort-AV: E=Sophos;i="5.90,290,1643702400"; d="scan'208";a="558173820" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.252.58.98]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 00:58:33 -0700 Message-ID: <3459875e-782d-d2bd-ba1f-c945e22e312e@intel.com> Date: Tue, 26 Apr 2022 10:58:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.7.0 Subject: Re: [PATCH V5 4/5] mmc: debugfs: Add debug fs error state entry for mmc driver Content-Language: en-US From: Adrian Hunter To: Shaik Sajida Bhanu , ulf.hansson@linaro.org, wsa+renesas@sang-engineering.com, yoshihiro.shimoda.uh@renesas.com, linus.walleij@linaro.org, digetx@gmail.com, briannorris@chromium.org, quic_riteshh@quicinc.com Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, quic_asutoshd@quicinc.com, quic_rampraka@quicinc.com, quic_pragalla@quicinc.com, quic_sartgarg@quicinc.com, quic_nitirawa@quicinc.com, quic_sayalil@quicinc.com, Liangliang Lu , "Bao D . Nguyen" References: <1650902443-26357-1-git-send-email-quic_c_sbhanu@quicinc.com> <1650902443-26357-5-git-send-email-quic_c_sbhanu@quicinc.com> Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/04/22 10:54, Adrian Hunter wrote: > On 25/04/22 19:00, Shaik Sajida Bhanu wrote: >> Add debug fs entry error state to query eMMC and SD card errors statistics. >> If any errors occurred in eMMC and SD card driver level then >> err_state value will be set to 1. >> >> Signed-off-by: Liangliang Lu >> Signed-off-by: Sayali Lokhande >> Signed-off-by: Bao D. Nguyen >> Signed-off-by: Shaik Sajida Bhanu >> --- >> drivers/mmc/core/debugfs.c | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c >> index 6aa5a60..2f5b63f 100644 >> --- a/drivers/mmc/core/debugfs.c >> +++ b/drivers/mmc/core/debugfs.c >> @@ -222,6 +222,29 @@ static int mmc_clock_opt_set(void *data, u64 val) >> >> DEFINE_DEBUGFS_ATTRIBUTE(mmc_clock_fops, mmc_clock_opt_get, mmc_clock_opt_set, >> "%llu\n"); > > A blank line would be nice here > >> +static int mmc_err_state_get(void *data, u64 *val) >> +{ >> + struct mmc_host *host = data; >> + >> + if (!host) >> + return -EINVAL; >> + > > I am not sure why you have left out some err_stats[]. > Why not all of them? At least, it needs a comment to explain. > >> + *val = host->err_stats[MMC_ERR_REQ_TIMEOUT] || >> + host->err_stats[MMC_ERR_ADMA] || >> + host->err_stats[MMC_ERR_CTRL_TIMEOUT] || >> + host->err_stats[MMC_ERR_UNEXPECTED_IRQ] || >> + host->err_stats[MMC_ERR_CMDQ_RED] || >> + host->err_stats[MMC_ERR_CMDQ_GCE] || >> + host->err_stats[MMC_ERR_CMDQ_ICCE] || >> + host->err_stats[MMC_ERR_DAT_TIMEOUT] || >> + host->err_stats[MMC_ERR_DAT_CRC] || >> + host->err_stats[MMC_ERR_CMD_CRC] || >> + host->err_stats[MMC_ERR_CMD_TIMEOUT]; >> + >> + return 0; >> +} >> + >> +DEFINE_SIMPLE_ATTRIBUTE(mmc_err_state, mmc_err_state_get, NULL, "%llu\n"); Also, if possible, please use DEFINE_DEBUGFS_ATTRIBUTE / debugfs_create_file_unsafe in this case >> >> static int mmc_err_stats_show(struct seq_file *file, void *data) >> { >> @@ -289,6 +312,8 @@ void mmc_add_host_debugfs(struct mmc_host *host) >> debugfs_create_file_unsafe("clock", S_IRUSR | S_IWUSR, root, host, >> &mmc_clock_fops); >> >> + debugfs_create_file("err_state", 0600, root, host, >> + &mmc_err_state); >> debugfs_create_file("err_stats", 0600, root, host, >> &mmc_err_stats_fops); >> >