From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: "chu.stanley@gmail.com" <chu.stanley@gmail.com>,
"robh@kernel.org" <robh@kernel.org>,
"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
"kishon@kernel.org" <kishon@kernel.org>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@hansenpartnership.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"Chaotian Jing (井朝天)" <Chaotian.Jing@mediatek.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"Peter Wang (王信友)" <peter.wang@mediatek.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>,
"kernel@collabora.com" <kernel@collabora.com>
Subject: Re: [PATCH v8 11/23] scsi: ufs: mediatek: Remove undocumented downstream reset cruft
Date: Thu, 05 Mar 2026 10:57:53 +0100 [thread overview]
Message-ID: <3472277.mvXUDI8C0e@workhorse> (raw)
In-Reply-To: <3aeee75e78fed2be92038c776463a231b94462f3.camel@mediatek.com>
On Thursday, 5 March 2026 10:14:47 Central European Standard Time Peter Wang (王信友) wrote:
> On Wed, 2026-03-04 at 15:53 +0100, Nicolas Frattaroli wrote:
> > @@ -2383,38 +2383,12 @@ MODULE_DEVICE_TABLE(of, ufs_mtk_of_match);
> > static int ufs_mtk_probe(struct platform_device *pdev)
> > {
> > int err;
> > - struct device *dev = &pdev->dev, *phy_dev = NULL;
> >
>
> Will there be a build error if phy_dev is removed?
> Please make sure that each patch can build successfully, one by one.
>
> Thanks
> Peter
>
>
>
>
Yes, these are the kinds of mistakes that happen when you ask someone
to pick apart patches for your downstream convenience.
I'll hand dealing with any further fixups and variable naming concerns
you have over to Angelo, as I can't be bothered to deal with you
anymore.
next prev parent reply other threads:[~2026-03-05 10:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 14:53 [PATCH v8 00/23] MediaTek UFS Cleanup and MT8196 Enablement Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 01/23] dt-bindings: phy: Add mediatek,mt8196-ufsphy variant Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 02/23] dt-bindings: ufs: mediatek,ufs: Complete the binding Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 03/23] dt-bindings: ufs: mediatek,ufs: Add mt8196 variant Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 04/23] scsi: ufs: mediatek: Move MTK_SIP_UFS_CONTROL to mtk_sip_svc.h Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 05/23] phy: mediatek: ufs: Add support for resets Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 06/23] scsi: ufs: mediatek: Rework resets Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 07/23] scsi: ufs: mediatek: Rework 0.9V regulator Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 08/23] scsi: ufs: mediatek: Rework init function Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 09/23] scsi: ufs: mediatek: Rework the crypt-boost stuff Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 10/23] scsi: ufs: mediatek: Handle misc host voltage regulators Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 11/23] scsi: ufs: mediatek: Remove undocumented downstream reset cruft Nicolas Frattaroli
2026-03-05 9:14 ` Peter Wang (王信友)
2026-03-05 9:57 ` Nicolas Frattaroli [this message]
2026-03-06 5:39 ` Peter Wang (王信友)
2026-03-06 12:53 ` Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 12/23] scsi: ufs: mediatek: Remove vendor kernel quirks cruft Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 13/23] scsi: ufs: mediatek: Use the common PHY framework Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 14/23] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property Nicolas Frattaroli
2026-03-05 9:33 ` Peter Wang (王信友)
2026-03-04 14:53 ` [PATCH v8 15/23] scsi: ufs: mediatek: Rework _ufs_mtk_clk_scale error paths Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 16/23] scsi: ufs: mediatek: Clean up logging prints Nicolas Frattaroli
2026-03-05 9:34 ` Peter Wang (王信友)
2026-03-04 14:53 ` [PATCH v8 17/23] scsi: ufs: mediatek: Rework ufs_mtk_wait_idle_state Nicolas Frattaroli
2026-03-05 9:37 ` Peter Wang (王信友)
2026-03-04 14:53 ` [PATCH v8 18/23] scsi: ufs: mediatek: Don't acquire dvfsrc-vcore twice Nicolas Frattaroli
2026-03-05 9:38 ` Peter Wang (王信友)
2026-03-04 14:53 ` [PATCH v8 19/23] scsi: ufs: mediatek: Rework hardware version reading Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 20/23] scsi: ufs: mediatek: Back up idle timer in per-instance struct Nicolas Frattaroli
2026-03-05 9:39 ` Peter Wang (王信友)
2026-03-04 14:53 ` [PATCH v8 21/23] scsi: ufs: mediatek: Remove ret local from link_startup_notify Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 22/23] scsi: ufs: mediatek: Remove undocumented "clk-scale-up-vcore-min" Nicolas Frattaroli
2026-03-04 14:53 ` [PATCH v8 23/23] scsi: ufs: mediatek: Add MT8196 compatible, update copyright Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3472277.mvXUDI8C0e@workhorse \
--to=nicolas.frattaroli@collabora.com \
--cc=Chaotian.Jing@mediatek.com \
--cc=Chunfeng.Yun@mediatek.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=broonie@kernel.org \
--cc=bvanassche@acm.org \
--cc=chu.stanley@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=peter.wang@mediatek.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox