From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A9E933F374; Thu, 5 Mar 2026 10:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772704829; cv=pass; b=rYqKn7CBH5Sc+LKSs6OcqiA1YxApJxjWRldMBNRYs8sXipsEvVfs7N+A1kjuy+1MT+iJpRaL75AxUMuqvKaoNnmpe0kzjNz98pogLKDpurEdNhMxlaXqGdEMIE2IgvFQCxykOg1gh/ABX5mmFrd0gaJ4uicoURII+hJ+w2XoRjY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772704829; c=relaxed/simple; bh=yTf9GYa92CxOR0v1gm9TC/TaEGiV9h9oOyqTiChyhQc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CeGNdwp89J4HgoEqukjQw0SH4cjuCInkA2wODUUWWuPRQumX422Bxxdcie9keod117lAKGoXhqKohsFSLOFKIVM42uameIKpmntcV5okj3T3Xif6d3E9J6B+6MDIV6g8TtNbpijfygH/hIxRq3zegUrjD2vS4UyryjzgN6LI700= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=J/301NWa; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="J/301NWa" ARC-Seal: i=1; a=rsa-sha256; t=1772704683; cv=none; d=zohomail.com; s=zohoarc; b=kBoMhSSPZC5RsRfS4lwUYt+DXbeKYd998viSF8OfQgMUxb/zXbxyemZauGhuLeYTbPBelQjuTfEL9D0+cWo40OIheo5HwWCwpwlhtF3FhqUusAxKkTY416Dmd3KJxG3Sfv/E4HjLm8ThGO3Xq0gjfknscHV4kjjKHfgvW8ob+Yc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772704683; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=t+dM/ivqOh9qFQC6P4MhMScrDFmdYfA44gwq4G7yKZA=; b=fK4RwTEpB/dukN63XUnC6gB0R4xTNhIruor1iiIurQIm8TsF4kKFxi+gMjRHWSoxFymTAVKJ+sVEYYCSrvj5kS8FLsPP41vixq+SkwRlXPTwlKClaT5CvK20ffWU7wnncuAFyu8PJwB95ylrXrsozTseCxJZpS1ZLScgCqos7R4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1772704683; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=t+dM/ivqOh9qFQC6P4MhMScrDFmdYfA44gwq4G7yKZA=; b=J/301NWaZdxu3OBlGpm+tcT8tF32LtInDWcbPlcVv41C/2xK55Pi9n2RO8pJgD/l wkCpA7kwqrt9OFuobYiiO8tC+AKWML/dxJuO+AITRr9jlC6DgJvNBBrTSC2C5FGya/f yyvNJiQC2PXlDeManSvq/+q1AWUAAinyKmpE1e2Y= Received: by mx.zohomail.com with SMTPS id 1772704680982221.39391748095557; Thu, 5 Mar 2026 01:58:00 -0800 (PST) From: Nicolas Frattaroli To: "chu.stanley@gmail.com" , "robh@kernel.org" , Chunfeng Yun =?UTF-8?B?KOS6keaYpeWzsCk=?= , "kishon@kernel.org" , "James.Bottomley@HansenPartnership.com" , "bvanassche@acm.org" , AngeloGioacchino Del Regno , "neil.armstrong@linaro.org" , "conor+dt@kernel.org" , Chaotian Jing =?UTF-8?B?KOS6leacneWkqSk=?= , "lgirdwood@gmail.com" , "vkoul@kernel.org" , "krzk+dt@kernel.org" , "p.zabel@pengutronix.de" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "avri.altman@wdc.com" , "martin.petersen@oracle.com" , "broonie@kernel.org" , Peter Wang =?UTF-8?B?KOeOi+S/oeWPiyk=?= Cc: "linux-scsi@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-phy@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Louis-Alexis Eyraud , "kernel@collabora.com" Subject: Re: [PATCH v8 11/23] scsi: ufs: mediatek: Remove undocumented downstream reset cruft Date: Thu, 05 Mar 2026 10:57:53 +0100 Message-ID: <3472277.mvXUDI8C0e@workhorse> In-Reply-To: <3aeee75e78fed2be92038c776463a231b94462f3.camel@mediatek.com> References: <20260304-mt8196-ufs-v8-0-5b0eac23314f@collabora.com> <20260304-mt8196-ufs-v8-11-5b0eac23314f@collabora.com> <3aeee75e78fed2be92038c776463a231b94462f3.camel@mediatek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Thursday, 5 March 2026 10:14:47 Central European Standard Time Peter Wan= g (=E7=8E=8B=E4=BF=A1=E5=8F=8B) wrote: > On Wed, 2026-03-04 at 15:53 +0100, Nicolas Frattaroli wrote: > > @@ -2383,38 +2383,12 @@ MODULE_DEVICE_TABLE(of, ufs_mtk_of_match); > > static int ufs_mtk_probe(struct platform_device *pdev) > > { > > int err; > > - struct device *dev =3D &pdev->dev, *phy_dev =3D NULL; > >=20 >=20 > Will there be a build error if phy_dev is removed? > Please make sure that each patch can build successfully, one by one. >=20 > Thanks > Peter >=20 >=20 >=20 >=20 Yes, these are the kinds of mistakes that happen when you ask someone to pick apart patches for your downstream convenience. I'll hand dealing with any further fixups and variable naming concerns you have over to Angelo, as I can't be bothered to deal with you anymore.