From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1424118AbcFMO2m (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Jun 2016 10:28:42 -0400
Received: from mout.kundenserver.de ([212.227.126.133]:63050 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1423255AbcFMO2k (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Jun 2016 10:28:40 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Binoy Jayan <binoy.jayan@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johnny Kim <johnny.kim@atmel.com>, Austin Shin <austin.shin@atmel.com>,
        Chris Park <chris.park@atmel.com>, Tony Cho <tony.cho@atmel.com>,
        Glen Lee <glen.lee@atmel.com>, Leo Kim <leo.kim@atmel.com>,
        devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] *** staging: wilc1000: Replace semaphores with mutexes or completions ***
Date: Mon, 13 Jun 2016 16:29:56 +0200
Message-ID: <3475016.uenfZZHUnB@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1465814259-3009-1-git-send-email-binoy.jayan@linaro.org>
References: <1465814259-3009-1-git-send-email-binoy.jayan@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:0uogWtvGn8JoEVVf/pqHvikR6nWmDWEFQZ1Jc6L94jI+DIwWqBR
 FWVU7ChFAdaUQWbCJ8gUCCiMzWbDVATreLudIrcMfh8BPxpxA3k596wlSV7K/7+T8L8U2s6
 1sOl9L76HW4LhE5UR3TdiXnPRYFByR5McQqQYo7OoNE35bMxSY+dTsEQW3ae8H9QDyvXjiP
 SWGlv/DRWDu21+Ex6HS2w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:iEQJLI/a83I=:8fkKRD2b4DwVvtC09CUnGV
 h7OVHvqQ9zxxBSnFozm0OG6hsfpSoy4cDyuJAHipLUrHj9wMAisS7ncMyz1OjVvpphZCzk8LJ
 OgEa8xv7lPg7rEWW4lp8DTr8vhtjguuRby5NKzX8vAdhsVmn8ymF78scdyjfqT/y6vXDISqpL
 dImXn0mJgFlvrr3+blteQefQCbR5G5B3pWgy9Jp4k0dbhhiD8JSARIUgl3dtcbw5hJkTbMG90
 dUHNIann242Xk+Nm6UePqeCbMxYVhLywfiXLfziC0UX/I4jErvbDjPgIF4KIH4oAkPLqNfUs/
 aVtTg/ZfOF847wjJatDMUiS8jiFN2ex4uqTuJ7qQFQVwO5/5F+ZmRk2SzMMdBOOl/K2FQ8GKs
 g8bh67OFtt3FmjiuVMhneFyyeW57aixguLvv9QaaHsRHktWX27R/ubq0GQTkA158zPZ2f2AbK
 2SjsBCCTQSK9rLly2b8gCXxFjobyt+8/KjGEDGw1kS0TdcFgR7ipBTZmacjd57YiBgPaINzFN
 CfyvGymUSHTcubXjm3uyizZzkkBIXSMRGSTSFZxkU8Lc3P0L4hm1nHCiqFDOjJY3Na/gSfW5m
 vNHVVoL5WAWBNCkYkAeAYpZ3Gw1rgA4nBjzXGrboQbZXkg8/Go4+W8zr0nDkAwVF8tknJcSZM
 z5oi6ggmHbm4y2wdSyCaz+An1jdS07gr+yPXOarP0LK7TFIslO4e7Tuk1pOCv8pHw7XB7GZCy
 oZl6cgiECGTXlctO
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, June 13, 2016 4:07:32 PM CEST Binoy Jayan wrote:
> Hi,
> 
> These are a set of patches which removes semaphores from:
> 
> drivers/staging/wilc1000
> 
> These are part of a bigger effort to eliminate all semaphores
> from the linux kernel.
> 
> They build correctly (individually and as a whole).
> 
> NB: The changes are untested
> 

Most of these look really good, but I've commented on what I think
should be done differently, most importantly using a work_queue
rather than a completion to replace the semaphore in patch 6.

Maybe you can resend the first five patches after addressing
my comments so we can get those tested and queued already while
you look into reworking patch 6. Let me know if that one ends up
being more complicated than I thought so we can come up with
a different approach.

	Arnd