From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CED791EFFA3; Mon, 3 Mar 2025 10:45:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740998718; cv=fail; b=MAFTscYLr/yiXClNkyhuNqsI3a9Ci19xeH3SV74dQh72bNedGyAEkzTQ+l8rTu3G5hsJdB0L5RT7mXaj6fTzDNOE9QsVVy15t9NpxI+AeyQ6AcUlChi3hT07hSujcUIOMaGyAGJ4O4DoNSvFBPPHsVUmF56HytLqfcgKrNnwYZc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740998718; c=relaxed/simple; bh=Yl07lTBACqRnT5qnZl3ZRkwoRmlfqt7+hkfn2Bp/9Os=; h=Message-ID:Date:Subject:To:References:From:In-Reply-To: Content-Type:MIME-Version; b=lMft8ymadvN8V5OkvTm3jBzwPU++9xmeTkNsuI6c3NwPI+S2x8VlyyQaahqzxRzI7ivjQT7oRwklqJWD0xaKMPGTyBvHKClOByldAQraa76M5mO4kpK7YfJIS/ftrtxuegwCfDOu8eH3R46gUt28adPxtvTtkwwlnfGTi7IvZXg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=INw74Huw; arc=fail smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="INw74Huw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740998717; x=1772534717; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=Yl07lTBACqRnT5qnZl3ZRkwoRmlfqt7+hkfn2Bp/9Os=; b=INw74Huw5GDEaUH5zWbnkDYNXlfuX9Av0FJq8xRC9pL7nsgE2SoV/bG7 I66evqa2RgayK/4EKa93M61pX9apnteQHZreaj7VNtdvmBuZJMIDnlve/ FvZ3OwVEf3lNpoibsv+mK23biWblsX/nUq69Jm5lksPR7VKLlV/Ct9LS0 HrMoj/46Lc8LJS53DdzABvWeeWxZkM53uGR4mdQf9GqC6upUcj8D0UE2r a+369yIAe1qkep4abb8ITHuBIN7XoJvTawZuHc7WFpWNurkT3R4QG5DzZ ughIy2WzC5t8II8ueLew0YhzPfrBvn5bcmlmZAvgTenkZ24VFblBgR1us w==; X-CSE-ConnectionGUID: PRMZIoxMQ7Sp0BdqEvUqTQ== X-CSE-MsgGUID: pCZmyj3sTeua+v6vdkyncA== X-IronPort-AV: E=McAfee;i="6700,10204,11361"; a="41754566" X-IronPort-AV: E=Sophos;i="6.13,329,1732608000"; d="scan'208";a="41754566" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2025 02:45:15 -0800 X-CSE-ConnectionGUID: a8D6vwPASIuArQdmmQtUYA== X-CSE-MsgGUID: jrvGDZ8TTGqm62AJLWVKRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="118883303" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Mar 2025 02:45:14 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 3 Mar 2025 02:45:14 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Mon, 3 Mar 2025 02:45:14 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Mon, 3 Mar 2025 02:45:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L/HBs8I6Kp1WlhypRTpJ3mYX4tPBlqwnr15IzR0U30gDpwmPIziMqWAMSSOplJyEWwKNY5F5ocfj42SBS6+WjGltYpNX16aM+HPNXXQB/52DM+DY4NFDtdaMyF6kqe6bs3STCcYHoGCYwFz23VVj0G/zNncWZgNR+VPGe2bgjfytF0CNmcAsd9n44qKvd9MtigvTuYxtw2CpPHmX+6mQ5J8OJWveL7MfENiiTDY/V7I/UEPJVpasykBFXiGEDF4KqvD6zvpGdTUkVEM+j5R6nmk+cSHihgYR1bPrtfrK5tSzClXvEcAwNkNtGWKnD3uzgXgsCTQIpmSpMe7GZPhGwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ddyMWDWrvdPkKrtnnxufUJeZYwcdKpcdlMiancOUjQ=; b=VwrXG8brGZ9BdS5W4Us32TMlQeVGFczU/eE23B5V6T2BxbjIKzlxnYeT8XUgfPjpM7/FS7+usROIZKVw2HtbEWTQ4usvkuuUr1/8UGj4XvZdy26GmfrtJC4+FHCwwMbvBR8qOE18qps5R6n+YnhsmHZj6GXmq5PcxVxrI2cb/swebhOqVZrhGAy6ixZ/TOk1adJ7BVxBE0irj8PC+tkRVMW4QONAGpOr7oCXEk4192KL24FIVne54ZZpv4dy5H5MirGGVzAdXcbw2ovtNM1MmGwh77p1fbw2OuKAY8yZexAxtvpWGnMEIYKymWAqdy+rvUnwLloKfIYintboFiYnZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BYAPR11MB3605.namprd11.prod.outlook.com (2603:10b6:a03:f5::33) by SN7PR11MB8044.namprd11.prod.outlook.com (2603:10b6:806:2ef::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.27; Mon, 3 Mar 2025 10:44:44 +0000 Received: from BYAPR11MB3605.namprd11.prod.outlook.com ([fe80::1c0:cc01:1bf0:fb89]) by BYAPR11MB3605.namprd11.prod.outlook.com ([fe80::1c0:cc01:1bf0:fb89%4]) with mapi id 15.20.8489.025; Mon, 3 Mar 2025 10:44:44 +0000 Message-ID: <34795c29-d256-49ce-9d01-435f8cd91611@intel.com> Date: Mon, 3 Mar 2025 12:44:33 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/12] perf script: Make printing flags reliable To: Leo Yan , Arnaldo Carvalho de Melo , Namhyung Kim , Ian Rogers , "James Clark" , Mike Leach , "Mark Rutland" , Alexander Shishkin , Jiri Olsa , "Liang, Kan" , Will Deacon , "Graham Woodward" , , , , References: <20250217195908.176207-1-leo.yan@arm.com> <20250217195908.176207-2-leo.yan@arm.com> Content-Language: en-US From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <20250217195908.176207-2-leo.yan@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: ZR0P278CA0149.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::11) To BYAPR11MB3605.namprd11.prod.outlook.com (2603:10b6:a03:f5::33) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR11MB3605:EE_|SN7PR11MB8044:EE_ X-MS-Office365-Filtering-Correlation-Id: 499b6e7b-7b67-4966-a7cc-08dd5a406875 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|366016|376014|921020|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QU5IWG1WQkMyenJURHJkRG5NMXJjTW4vZlZUcU9QQnpkSVJOMjVoQk9JUmVm?= =?utf-8?B?Yy83ZUdqdmxBSjZJYjFsQmhONEpwNDVDdDh0R1RYcisxck04NitMZGpIODVT?= =?utf-8?B?V0xVZUtQbUp4V3B0OEFwbTQzWFdSR3JqTTFlTWQ3eWRtdE5GZWl4WElRWkRY?= =?utf-8?B?bTRVUWpzMWhXOVR4amh4VUNHOGFGcHJoVWVkYVQzVzFDekdJYXBzWmtBRG5G?= =?utf-8?B?Uy9rVzltK0I2UzAwdjdWTFZTanFmcG1mTGlha3NHNm5wcWZaakgxaGdyRzQz?= =?utf-8?B?WnNPYk9sYkNUT0NuVGhYL3lBTG4xdHlIQlBtVzlTamJOaGcxVXZsSnp1dy9w?= =?utf-8?B?K1dCSDlncDYwRDBGcUtCbEZjN1ZTN0xSUFVjWlE5ekNlam53cEZIcHd1WnR5?= =?utf-8?B?eFp0Q3lkdW4zN2lISjFSWnRoekxGd2dNM3BuYVZ6ODVEZjRnY2xHSndWaW5h?= =?utf-8?B?TDA1WUZEdzlucGF2QUwvQmRubXp6d1ZXTUdoa1lIS2pZeWovQ3BhVERzWndo?= =?utf-8?B?YW9qNGVvZ1VITjloSlB5VHdjaDY3VWFtZTlJb3M4d1hWaEVGMXlKTmpUb0Mv?= =?utf-8?B?OWo0YzNOWHRJOXhTY01jTyt2SXNocTQvYVI5UU9VVzJ3L0VsQysrYWZPKzZO?= =?utf-8?B?QzB0KzZGZjJaeU1BTUxGMFBMdU1PTS9FRExpR3BwTHBmQzJQUEFYUXd5M2tm?= =?utf-8?B?TEJtMDRZNlc1S09hNFlLSmtkdDlhSCs1cENWQ0hrUGpMazNLcmZyUnRwbjdF?= =?utf-8?B?RVo1VFk5NEprcEVWblZxd3JNZjl6K0NaTFU5cHlwRm00UUh1WmVFTzBtWkpU?= =?utf-8?B?SC9Za25td0JRZjF5TURMVWtTWGEwMTdMWFBYRUREV1BpdUFBemZrU21NTHNo?= =?utf-8?B?eFdkK1Q0ZGNGeXBITzVHS3hhQkFiQTFEcFE4MzJqaURTZnhPOTZaZ2t0d040?= =?utf-8?B?dnZpY1hMNEVsS1dxZzZrVVZBdWF3TzV5N3dXbUZTaGdiT3pQSDVYMHJhN1ZZ?= =?utf-8?B?QlNydzlCTlVsclM3RGxDYVNrN2Y4UHRLVTdpWWNxVzg5MDdRVEZQSStPc0dL?= =?utf-8?B?eWpnQ1M5S293ZUZXTzd1UlZLWGMrbGMzRUFUdDA5QjRPa0hIbnUrUWdwY3Fn?= =?utf-8?B?RXowNytqR0t6MkhiMTkzaW1ZaWFSc1BtditIMXVGT3ZjdTZjZnkyOU5DcUhx?= =?utf-8?B?aUg2azc0a3NmOGRnRGl2UlhxaU9JMlJzYjlUVlkyNFM3cGZjbkNkZFdWaFFR?= =?utf-8?B?UGV4VWpMTGozRW5HOEdrcEUwMzE1bUJmOVRlbVk1aSthNFVqUENYdUdGNytt?= =?utf-8?B?WmlTQzRkWXNTRHVka2M5ZXlZd1BMNDR5dlRsZm9mQ2dVZkxKa0R6OGJyKzJL?= =?utf-8?B?RlhPUmxjeFkrTnpaSmNPaFRLblh5WXFtOHhoL3dKWWhvSk5EVyswUzBjOElv?= =?utf-8?B?UzRhTHNhaG1NcHZNeVU2WHljOWYvMEJvZ1pvV05McGFtZkhtTTN4SlpHeS84?= =?utf-8?B?YW1HQWN3RldhVmpYQkxGZnRXTmg4WTFBMTB6Q013Nmo5Sk9xWGRyNWh0cmdx?= =?utf-8?B?MjJKaDQxOWw5b1N6Z3NhbGxqSzJlenJNdE8ybjZjRHM2SzBvWmN2WHZhd3BZ?= =?utf-8?B?WEFJc0lEWmxxS1JWdzJGbFdOQ0V5ZHd3c08rMUY1Z3F2RDByQ0R6MmJMQTQx?= =?utf-8?B?aFQxUTU1NEV2VlhQSTI4ZGpKMlM4alBPWjN3S2pMMHFvOW1IYnVxSnRYajlU?= =?utf-8?B?Q2tqYUQ0d2JBWmZnbnRJdlpiZG4rcDBzVkVqQmFDVDZBREdGSXk3Y1JWU3dl?= =?utf-8?B?VFJVeVFrK0E1WWJjeTltZ3RkWlVpalJRRDFFbk9jOUUvR0RTOU56OWpVRmFZ?= =?utf-8?B?b054UTBxZ2thUlZDajZpUThxRy9BRTNQaUVLWU1wQWJmOG5VL1U3SHNtY3Av?= =?utf-8?Q?O7jJJc91yjM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3605.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(366016)(376014)(921020)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGpSQlM2Sml0R25PenpOUVlYc3F5UlVma2lCSzBaZldBQmoyMmdIUTlrdTAv?= =?utf-8?B?WUM0Mk1pYjJVTWdrQ2lDaTNzYVREY3oyRkxOeGU4L044TzBtUG1CaHh5a3Z4?= =?utf-8?B?dnlqSDArcDhoMkYrVUc1bWVFQWJhanVBUktGOFdCZ25GWmluQmpZK0wramNx?= =?utf-8?B?Q3h0NTN2STNFNDRYdzliOWhKYzltaXRsZkVSWityemlhckp3YVEzZlczQVBF?= =?utf-8?B?Z3krSUpreWoyNk5QMUgwMi9TQUY5SHJpem80K0s5MWZXSkNVNHlhc1l3WjZI?= =?utf-8?B?UVhFRXRDL0g4c01QZEJqS2szamZjb0dpalpaRmM0S0RGN3loWmx4NEYzVXJp?= =?utf-8?B?OUU5enZhdi9MSGJFaUlnZXhJQytDZTBZMDJMODBuMzNUSCsraFZnbm1iREox?= =?utf-8?B?YkNZSkZWUHBXRkxXZlo4RmdSTk1nQW1tRzc4bFhnNVFmOUJJd3l6ZEdGaE5a?= =?utf-8?B?OGhpNTBNaWI3NDdyVjlYcHlMdW4rc3lDZGp0UkFrdXhqNFdHRk9QWk1rMWpv?= =?utf-8?B?eERlMmhESFY4VnRSa21mTVFYb3FGaU9ZSWpwVnBPVC9OWUJ5Mnl1S3VhZUpa?= =?utf-8?B?UmpNS3oyS0hNc0Z1dEN3ay9abU9EUTBjRjE2Q1VYeFF0WVpTZTJrcUhCUEFy?= =?utf-8?B?VEJlUFVsb0dEbk01c0tidGMwNXlhYVpmaFYweVRCZ3pyK1p3dlYrVFA3QlEy?= =?utf-8?B?YnlEd3VKVnd5dFJTa2IrbVBYaTF4MWlIeWprTXVVTlFhRTBUQVVUcGpQL1Fz?= =?utf-8?B?Ky9mZDhYblVTenZPTkJvQ1oyUkYrbSswZHY3Z1BQeEk4UEM2NU91S0JadjEw?= =?utf-8?B?Z0RiOVNUbGlVUG1KbUhRVnBSN082ZFVITEtaQkYzRkdMY05vQnVrV29vdWp2?= =?utf-8?B?S0FoK0t4UVpDMElFVkxiWmk3L3ZGdEN2b24rN2w3cng4dXhUYlVoMzBmU01H?= =?utf-8?B?dSthU3pPcE51dFhIU0ppS3FEOVprcVkvSWs0Q2lZUkdBWGV3TnJpeHplaXFH?= =?utf-8?B?Q2x0QVFDSklDMktFT2VkVFBiL25lSU9OSWJMcytoV2g2TGU1N0hvNDkrRWxi?= =?utf-8?B?VUg1YUFKbFJNbSsyQUtXNk8xMS83NHJmYURvcmJ2ZW9xZUI4dFUwS2ZTVklm?= =?utf-8?B?WFN6ZldXdjlTRGJXSEZ2M0NiSUR3WllvaUxwOEgyV1cyN0h2N3RFZFpRV1M3?= =?utf-8?B?Rlp3dmtIMVpEOTZEcEhYUzhobWNqUEVKOHBLYnpjWmtJTTR3S1dWSmlhNnhW?= =?utf-8?B?cTY2ZW55WVl3T2VWM0hNVlp3ZzF4UkRhRkFRTmtHWjNqSGtVWDNKcGlyM0ww?= =?utf-8?B?bkdObUd3blBkOTkrVkJ0eE9acktscFl4SDUxcU91Y1RLejc3bStuVnZQRVRp?= =?utf-8?B?S0N4cnJXd1hmQUJRK0N4MVVRUTJjczVPM0VEUEhya3BOWDRpTkREMHc2QmZQ?= =?utf-8?B?SEhQK21MblFwbU4rQkl6Q2ZTWDlMMUwrTEdKZUZiUkRQQU5lTWpHZmsyZDBu?= =?utf-8?B?WGQxQ3FLNHpid2lqNmoyaDlUSTVGUHM0Z2VQbE9jM3l3TjlSQ20rYjZTRy82?= =?utf-8?B?T0Vmb0hsdldTQytRUE9YSTY5VzFCczVQKzNFYWsxV3Mvb3lwZnhJMXNYMmRn?= =?utf-8?B?SEVjNVEyOC9ZREZDL21sVi9WdUJCL3l6SHE0RHVta2VnT3F5TWplQUQyaHVB?= =?utf-8?B?cEl0REhXT3k4VllTNnpoWTNLNkVFL2FNSjdLQW1GbVhjN3JSdExQZ0hMM1JK?= =?utf-8?B?a1hLdWZTc212enpRSjJaNWVhdmVlMDFEdTltc1lBVUIxRVFqMWhaT080REo3?= =?utf-8?B?MnJBTXhzMjk3V2Y0MU1PU1dLeGFYY3BkV2YzcVJ2Z25Id0lrMzd2OW0vZURS?= =?utf-8?B?R1hHTkhCRE1iUkhMUFV4YzlHL2lIZ0FjSGZCRU9EN0JmbVNobXpMUWExSTVa?= =?utf-8?B?ZjZvRUpGTHR3dFVBUHFXTThWeHVFdWhmNFYzUWlTTXRjRzlDSmQ0RWdET3Fi?= =?utf-8?B?YlhXYWR0Q0JPTEJyRHZOMU9ZY1pmT1ZWT1BCVlZOZXRvdk1FWW80UHJxSFY5?= =?utf-8?B?WDVQZVZ4Vyt6OWdqMjE2ajNmVXZldWgxMlMvVjNNNG1QN3I5K0x3Qi9Ma01B?= =?utf-8?B?TzdObG1rWGRyZ21lb1l6eTc4S0FHai9ad1Q2RFlJZ2c2QUx0RkRuWXJtSksz?= =?utf-8?B?Zmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 499b6e7b-7b67-4966-a7cc-08dd5a406875 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3605.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2025 10:44:44.0022 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g2tybsl1CNnSU4YdzKadExW+7BWqPNLkmtpxaUq1J3D8JnfYO7UjL+n2jzDclqSXiVORC62USvye7jn68UB96g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8044 X-OriginatorOrg: intel.com On 17/02/25 21:58, Leo Yan wrote: > Add a check for the generated string of flags. Print out the raw number > if the string generation fails. How does it fail? > > In another case, if the string length is longer than the aligned size, > allow the completed string to be printed. > > Reviewed-by: Ian Rogers > Reviewed-by: James Clark > Signed-off-by: Leo Yan > --- > tools/perf/builtin-script.c | 10 ++++++++-- > tools/perf/util/trace-event.h | 2 ++ > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > index d797cec4f054..2c4b1fb7dc72 100644 > --- a/tools/perf/builtin-script.c > +++ b/tools/perf/builtin-script.c > @@ -1709,9 +1709,15 @@ static int perf_sample__fprintf_bts(struct perf_sample *sample, > static int perf_sample__fprintf_flags(u32 flags, FILE *fp) > { > char str[SAMPLE_FLAGS_BUF_SIZE]; > + int ret; > + > + ret = perf_sample__sprintf_flags(flags, str, sizeof(str)); > + if (ret < 0) AFAICT ret is always >= 0 > + return fprintf(fp, " raw flags:0x%-*x ", > + SAMPLE_FLAGS_STR_ALIGNED_SIZE - 12, flags); > > - perf_sample__sprintf_flags(flags, str, sizeof(str)); > - return fprintf(fp, " %-21s ", str); > + ret = max(ret, SAMPLE_FLAGS_STR_ALIGNED_SIZE); > + return fprintf(fp, " %-*s ", ret, str); -21 means the field width is 21 and left-justified. It should not truncate the string. > } > > struct printer_data { > diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h > index ac9fde2f980c..71e680bc3d4b 100644 > --- a/tools/perf/util/trace-event.h > +++ b/tools/perf/util/trace-event.h > @@ -145,6 +145,8 @@ int common_flags(struct scripting_context *context); > int common_lock_depth(struct scripting_context *context); > > #define SAMPLE_FLAGS_BUF_SIZE 64 > +#define SAMPLE_FLAGS_STR_ALIGNED_SIZE 21 > + > int perf_sample__sprintf_flags(u32 flags, char *str, size_t sz); > > #if defined(LIBTRACEEVENT_VERSION) && LIBTRACEEVENT_VERSION >= MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)