Re: mm: zswap: fix crypto_free_acomp deadlock in zswap_cpu_comp_dead

Herbert Xu
2025-02-26T02:10:36Z

On Wed, Feb 26, 2025 at 02:08:14AM +0000, Yosry Ahmed wrote:
>
> Could you please:
>
> (1) Explain the exact scenario in the commit log, I did not understand
> it at first, only after looking at the syzbot dashboard for a while (and
> I am not sure how long this persists).
>
> (2) Move all the freeing operations outside the mutex? Right now
> crypto_free_acomp() was the problematic call but it could be
> acomp_request_free() next.
>
> Something like:

Looks good to me. Feel free to send this patch since it is your
system after all :)

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt