From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397AbcGRTgO (ORCPT ); Mon, 18 Jul 2016 15:36:14 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:61165 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375AbcGRTgL (ORCPT ); Mon, 18 Jul 2016 15:36:11 -0400 From: Arnd Bergmann To: Brian Norris Cc: Cyrille Pitchen , linux-mtd@lists.infradead.org, nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com, marex@denx.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mtd: atmel-quadspi: add driver for Atmel QSPI controller Date: Mon, 18 Jul 2016 21:35:39 +0200 Message-ID: <3482823.TCe8doMvLu@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160716004507.GD76613@google.com> References: <20160714013242.GG54628@google.com> <20160716004507.GD76613@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:lPGAiBf3ABN/6cxCbfbGZzvLLUqYrzmaS7jUdz88XJh+R8dNy7J Tf2tSGItib7DzofpXSeVGiyz3BJxTHkRKHOKkKgxttt95OvYYOv6oa/O8ddlcjfE5P5xVj4 4cGdh/MCAis1A3yMGBopGcEf7Oczy5TsLWRQdTaeIhwBzTjPivrRs9LGr4FTggw87aEtc3q K4hflmYE16pbeNTfzp4LQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:heEw/JREc1s=:4r9AFHMD6RJphtrxcMxYmI RWFEOJzdLMqgL3bLgPnr2vCn7Qq2HCHEyrkSnFLzqqsOs71R/U0ntilK1uuJrwD9BsH95i2p2 /D4138h4x7PZjSrNXw7uOPKVstUTszYBV0osetHtbjYb5nxFjG47Cj0wY/UsMn+GqpD2oAWpc BIsNDIqjZJZ/zC7RsuIFbd3LiC75ty72LEEwwRkyyM0AKB5zsu4PZml4NjxYZoVPvqqeh5X4S EJuvq2oLP/vWvSktDP0eKHy86tL6bLXeaagOFIXjD3IjTe038Ntr+lZng8zMGBdv5L2QXFjDE bylxn/LlAzdSfqkeBYSq6IBeQQWbjOg40ET6aA1r1F7ayZCcF+CfmTlNrX/9zDZHJRf8lyeoo h1jiO74UEcKLflh3BpeYn5GydZ14G/VKcXYwI3/aZ/hfw5MfaR1MnX70Idspo64JMYXVQjDI6 XkbNUzy1euU67v/yANpdPhBGVadYZUezQS4BH6eiN2vlJfcRvDqqy5cIFRX2v/ydGIBVhLVMR WQ+IoREIaqEFhgqoYfOdR/VuWmN/PuQtRiASAu84gDPWcP2Uyg+eplPOMbLdGqEmZOOz7jVrr nG67u0eGnQ3wliMXCbKZsaOmjy2r8gSNCufSCbuSdHPPu3yqVP4Usod5FUif9jTBLQpPxXEvD p2ciAkKaSCu/bbIEtRTdmJc3s+Ythx2zR7TYRXgCuVgkfrE/EPNYhivDDcsk3ibmGGF7EIk1I qw9QvGs1VKhTZNs3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, July 15, 2016 5:45:07 PM CEST Brian Norris wrote: > Applied to l2-mtd.git with that fixup. I'm getting this build error now on a randconfig build: drivers/mtd/built-in.o: In function `atmel_qspi_run_command': :(.text+0x1ee3c): undefined reference to `_memcpy_toio' :(.text+0x1ee48): undefined reference to `_memcpy_fromio' On ARCH_EBSA, which doesn't build the file that contains the two functions. I don't see any other driver on ARM using those two functions directly. What is the specific reason for using them here? Do you require byte-wise accesses, or could you use the normal memcpy_toio/memcpy_fromio that turn into aligned 32-bit word accesses instead? If you have to use the non-portable functions, maybe we can just make the driver depend on !ARCH_EBSA? Arnd