From: Wu Fengguang <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Wu Fengguang <wfg@mail.ustc.edu.cn>
Subject: [PATCH 10/32] readahead: rescue_pages()
Date: Sat, 27 May 2006 23:48:59 +0800 [thread overview]
Message-ID: <348745089.22899@ustc.edu.cn> (raw)
Message-ID: <20060527155130.538411854@localhost.localdomain> (raw)
In-Reply-To: 20060527154849.927021763@localhost.localdomain
[-- Attachment #1: readahead-rescue-pages.patch --]
[-- Type: text/plain, Size: 3165 bytes --]
Introduce function rescue_pages() to protect pages in danger of thrashing.
Signed-off-by: Wu Fengguang <wfg@mail.ustc.edu.cn>
---
mm/readahead.c | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 87 insertions(+)
--- linux-2.6.17-rc4-mm3.orig/mm/readahead.c
+++ linux-2.6.17-rc4-mm3/mm/readahead.c
@@ -682,6 +682,93 @@ unsigned long max_sane_readahead(unsigne
}
/*
+ * Adaptive read-ahead.
+ *
+ * Good read patterns are compact both in space and time. The read-ahead logic
+ * tries to grant larger read-ahead size to better readers under the constraint
+ * of system memory and load pressure.
+ *
+ * It employs two methods to estimate the max thrashing safe read-ahead size:
+ * 1. state based - the default one
+ * 2. context based - the failsafe one
+ * The integration of the dual methods has the merit of being agile and robust.
+ * It makes the overall design clean: special cases are handled in general by
+ * the stateless method, leaving the stateful one simple and fast.
+ *
+ * To improve throughput and decrease read delay, the logic 'looks ahead'.
+ * In most read-ahead chunks, one page will be selected and tagged with
+ * PG_readahead. Later when the page with PG_readahead is read, the logic
+ * will be notified to submit the next read-ahead chunk in advance.
+ *
+ * a read-ahead chunk
+ * +-----------------------------------------+
+ * | # PG_readahead |
+ * +-----------------------------------------+
+ * ^ When this page is read, notify me for the next read-ahead.
+ *
+ */
+
+#ifdef CONFIG_ADAPTIVE_READAHEAD
+
+/*
+ * Move pages in danger (of thrashing) to the head of inactive_list.
+ * Not expected to happen frequently.
+ */
+static unsigned long rescue_pages(struct page *page, unsigned long nr_pages)
+{
+ int pgrescue = 0;
+ pgoff_t index = page_index(page);
+ struct address_space *mapping = page_mapping(page);
+ struct page *grabbed_page = NULL;
+ struct zone *zone;
+
+ dprintk("rescue_pages(ino=%lu, index=%lu nr=%lu)\n",
+ mapping->host->i_ino, index, nr_pages);
+
+ for(;;) {
+ zone = page_zone(page);
+ spin_lock_irq(&zone->lru_lock);
+
+ if (!PageLRU(page))
+ goto out_unlock;
+
+ while (page_mapping(page) == mapping &&
+ page_index(page) == index) {
+ struct page *the_page = page;
+ page = list_entry((page)->lru.prev, struct page, lru);
+ if (!PageActive(the_page) &&
+ !PageLocked(the_page) &&
+ page_count(the_page) == 1) {
+ list_move(&the_page->lru, &zone->inactive_list);
+ pgrescue++;
+ }
+ index++;
+ if (!--nr_pages)
+ goto out_unlock;
+ }
+
+ spin_unlock_irq(&zone->lru_lock);
+ cond_resched();
+
+ if (grabbed_page)
+ page_cache_release(grabbed_page);
+ grabbed_page = page = find_get_page(mapping, index);
+ if (!page)
+ goto out;
+ }
+
+out_unlock:
+ spin_unlock_irq(&zone->lru_lock);
+out:
+ if (grabbed_page)
+ page_cache_release(grabbed_page);
+ ra_account(NULL, RA_EVENT_READAHEAD_RESCUE, pgrescue);
+ return nr_pages;
+}
+
+#endif /* CONFIG_ADAPTIVE_READAHEAD */
+
+/*
* Read-ahead events accounting.
*/
#ifdef CONFIG_DEBUG_READAHEAD
--
next prev parent reply other threads:[~2006-05-27 15:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060527154849.927021763@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 00/32] Adaptive readahead V14 Wu Fengguang
2006-05-27 17:29 ` Michael Tokarev
[not found] ` <20060528120815.GB6478@mail.ustc.edu.cn>
2006-05-28 12:08 ` Wu Fengguang
2006-05-28 19:23 ` Michael Tokarev
[not found] ` <20060529030152.GA5994@mail.ustc.edu.cn>
2006-05-29 3:01 ` Wu Fengguang
2006-05-30 9:23 ` Jens Axboe
[not found] ` <20060530113221.GA8665@mail.ustc.edu.cn>
2006-05-30 11:32 ` Wu Fengguang
2006-05-30 12:29 ` Jens Axboe
[not found] ` <20060530143417.GA9126@mail.ustc.edu.cn>
2006-05-30 14:34 ` Wu Fengguang
[not found] ` <20060527155125.911021581@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 01/32] readahead: kconfig options Wu Fengguang
[not found] ` <20060527155127.522802387@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 04/32] mm: introduce PG_readahead Wu Fengguang
[not found] ` <20060527155128.472551240@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 06/32] readahead: delay page release in do_generic_mapping_read() Wu Fengguang
[not found] ` <20060527155129.001886224@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 07/32] readahead: insert cond_resched() calls Wu Fengguang
[not found] ` <20060527155129.653903854@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 08/32] readahead: {MIN,MAX}_RA_PAGES Wu Fengguang
[not found] ` <20060527155130.013773601@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 09/32] readahead: events accounting Wu Fengguang
[not found] ` <20060527155130.538411854@localhost.localdomain>
2006-05-27 15:48 ` Wu Fengguang [this message]
[not found] ` <20060527155131.200177171@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 11/32] readahead: sysctl parameters Wu Fengguang
[not found] ` <20060527155132.649338979@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 14/32] readahead: state based method - routines Wu Fengguang
[not found] ` <20060527155133.216888332@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 15/32] readahead: state based method Wu Fengguang
[not found] ` <20060527155134.715578802@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 18/32] readahead: initial method - thrashing guard size Wu Fengguang
[not found] ` <20060527155135.584918734@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 20/32] readahead: initial method - user recommended size Wu Fengguang
[not found] ` <20060527155136.503037461@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 22/32] readahead: backward prefetching method Wu Fengguang
[not found] ` <20060527155137.552915509@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 24/32] readahead: thrashing recovery method Wu Fengguang
2006-05-27 22:04 ` [PATCH 23/32] readahead: seeking reads method Ingo Oeser
[not found] ` <20060527155138.046726658@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 25/32] readahead: call scheme Wu Fengguang
[not found] ` <20060527155138.454809673@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 26/32] readahead: laptop mode Wu Fengguang
[not found] ` <20060527155140.035991503@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 27/32] readahead: loop case Wu Fengguang
[not found] ` <20060527155141.697607086@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 30/32] readahead: debug radix tree new functions Wu Fengguang
[not found] ` <20060527155142.129761018@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 31/32] readahead: debug traces showing accessed file names Wu Fengguang
[not found] ` <20060527155142.715530234@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 32/32] readahead: debug traces showing read patterns Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348745089.22899@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox