From: Wu Fengguang <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Wu Fengguang <wfg@mail.ustc.edu.cn>,
Bart Samwel <bart@samwel.tk>
Subject: [PATCH 26/32] readahead: laptop mode
Date: Sat, 27 May 2006 23:49:15 +0800 [thread overview]
Message-ID: <348745098.74680@ustc.edu.cn> (raw)
Message-ID: <20060527155138.454809673@localhost.localdomain> (raw)
In-Reply-To: 20060527154849.927021763@localhost.localdomain
[-- Attachment #1: readahead-laptop-mode.patch --]
[-- Type: text/plain, Size: 3330 bytes --]
When the laptop drive is spinned down, defer look-ahead to spin up time.
The implementation employs a poll based method, for performance is not a
concern in this code path. The poll interval is 64KB, which should be small
enough for movies/musics. The user space application is responsible for
proper caching to hide the spin-up-and-read delay.
------------------------------------------------------------------------
For crazy laptop users who prefer aggressive read-ahead, here is the way:
# echo 1000 > /proc/sys/vm/readahead_ratio
# blockdev --setra 524280 /dev/hda # this is the max possible value
Notes:
- It is still an untested feature.
- It is safer to use blockdev+fadvise to increase ra-max for a single file,
which needs patching your movie player.
- Be sure to restore them to sane values in normal operations!
Signed-off-by: Wu Fengguang <wfg@mail.ustc.edu.cn>
---
include/linux/writeback.h | 6 ++++++
mm/page-writeback.c | 2 +-
mm/readahead.c | 31 +++++++++++++++++++++++++++++++
3 files changed, 38 insertions(+), 1 deletion(-)
--- linux-2.6.17-rc4-mm3.orig/include/linux/writeback.h
+++ linux-2.6.17-rc4-mm3/include/linux/writeback.h
@@ -86,6 +86,12 @@ void laptop_io_completion(void);
void laptop_sync_completion(void);
void throttle_vm_writeout(void);
+extern struct timer_list laptop_mode_wb_timer;
+static inline int laptop_spinned_down(void)
+{
+ return !timer_pending(&laptop_mode_wb_timer);
+}
+
/* These are exported to sysctl. */
extern int dirty_background_ratio;
extern int vm_dirty_ratio;
--- linux-2.6.17-rc4-mm3.orig/mm/page-writeback.c
+++ linux-2.6.17-rc4-mm3/mm/page-writeback.c
@@ -389,7 +389,7 @@ static void wb_timer_fn(unsigned long un
static void laptop_timer_fn(unsigned long unused);
static DEFINE_TIMER(wb_timer, wb_timer_fn, 0, 0);
-static DEFINE_TIMER(laptop_mode_wb_timer, laptop_timer_fn, 0, 0);
+DEFINE_TIMER(laptop_mode_wb_timer, laptop_timer_fn, 0, 0);
/*
* Periodic writeback of "old" data.
--- linux-2.6.17-rc4-mm3.orig/mm/readahead.c
+++ linux-2.6.17-rc4-mm3/mm/readahead.c
@@ -16,6 +16,7 @@
#include <linux/blkdev.h>
#include <linux/backing-dev.h>
#include <linux/pagevec.h>
+#include <linux/writeback.h>
#include <asm/div64.h>
/*
@@ -796,6 +797,31 @@ out:
}
/*
+ * Set a new look-ahead mark at @new_index.
+ * Return 0 if the new mark is successfully set.
+ */
+static int renew_lookahead(struct address_space *mapping,
+ struct file_ra_state *ra,
+ pgoff_t index, pgoff_t new_index)
+{
+ struct page *page;
+
+ if (index == ra->lookahead_index &&
+ new_index >= ra->readahead_index)
+ return 1;
+
+ page = radix_tree_lookup(&mapping->page_tree, new_index);
+ if (!page)
+ return 1;
+
+ SetPageReadahead(page);
+ if (ra->lookahead_index == index)
+ ra->lookahead_index = new_index;
+
+ return 0;
+}
+
+/*
* Update `backing_dev_info.ra_thrash_bytes' to be a _biased_ average of
* read-ahead sizes. Which makes it an a-bit-risky(*) estimation of the
* _minimal_ read-ahead thrashing threshold on the device.
@@ -1722,6 +1748,11 @@ page_cache_readahead_adaptive(struct add
end_index - index);
return 0;
}
+ if (laptop_mode && laptop_spinned_down()) {
+ if (!renew_lookahead(mapping, ra, index,
+ index + LAPTOP_POLL_INTERVAL))
+ return 0;
+ }
}
if (page)
--
next prev parent reply other threads:[~2006-05-27 15:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060527154849.927021763@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 00/32] Adaptive readahead V14 Wu Fengguang
2006-05-27 17:29 ` Michael Tokarev
[not found] ` <20060528120815.GB6478@mail.ustc.edu.cn>
2006-05-28 12:08 ` Wu Fengguang
2006-05-28 19:23 ` Michael Tokarev
[not found] ` <20060529030152.GA5994@mail.ustc.edu.cn>
2006-05-29 3:01 ` Wu Fengguang
2006-05-30 9:23 ` Jens Axboe
[not found] ` <20060530113221.GA8665@mail.ustc.edu.cn>
2006-05-30 11:32 ` Wu Fengguang
2006-05-30 12:29 ` Jens Axboe
[not found] ` <20060530143417.GA9126@mail.ustc.edu.cn>
2006-05-30 14:34 ` Wu Fengguang
[not found] ` <20060527155125.911021581@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 01/32] readahead: kconfig options Wu Fengguang
[not found] ` <20060527155127.522802387@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 04/32] mm: introduce PG_readahead Wu Fengguang
[not found] ` <20060527155128.472551240@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 06/32] readahead: delay page release in do_generic_mapping_read() Wu Fengguang
[not found] ` <20060527155129.001886224@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 07/32] readahead: insert cond_resched() calls Wu Fengguang
[not found] ` <20060527155129.653903854@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 08/32] readahead: {MIN,MAX}_RA_PAGES Wu Fengguang
[not found] ` <20060527155130.013773601@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 09/32] readahead: events accounting Wu Fengguang
[not found] ` <20060527155130.538411854@localhost.localdomain>
2006-05-27 15:48 ` [PATCH 10/32] readahead: rescue_pages() Wu Fengguang
[not found] ` <20060527155131.200177171@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 11/32] readahead: sysctl parameters Wu Fengguang
[not found] ` <20060527155132.649338979@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 14/32] readahead: state based method - routines Wu Fengguang
[not found] ` <20060527155133.216888332@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 15/32] readahead: state based method Wu Fengguang
[not found] ` <20060527155134.715578802@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 18/32] readahead: initial method - thrashing guard size Wu Fengguang
[not found] ` <20060527155135.584918734@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 20/32] readahead: initial method - user recommended size Wu Fengguang
[not found] ` <20060527155136.503037461@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 22/32] readahead: backward prefetching method Wu Fengguang
[not found] ` <20060527155137.552915509@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 24/32] readahead: thrashing recovery method Wu Fengguang
2006-05-27 22:04 ` [PATCH 23/32] readahead: seeking reads method Ingo Oeser
[not found] ` <20060527155138.046726658@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 25/32] readahead: call scheme Wu Fengguang
[not found] ` <20060527155138.454809673@localhost.localdomain>
2006-05-27 15:49 ` Wu Fengguang [this message]
[not found] ` <20060527155140.035991503@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 27/32] readahead: loop case Wu Fengguang
[not found] ` <20060527155141.697607086@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 30/32] readahead: debug radix tree new functions Wu Fengguang
[not found] ` <20060527155142.129761018@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 31/32] readahead: debug traces showing accessed file names Wu Fengguang
[not found] ` <20060527155142.715530234@localhost.localdomain>
2006-05-27 15:49 ` [PATCH 32/32] readahead: debug traces showing read patterns Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348745098.74680@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=bart@samwel.tk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox