From: Arnd Bergmann <arnd@arndb.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH, resend] pch_phub: re-use native MAC address parser
Date: Tue, 04 Jun 2013 16:38:11 +0200 [thread overview]
Message-ID: <3489856.nvZgTyoe0K@wuerfel> (raw)
In-Reply-To: <CAHp75VdrXdA7uwpYoo5To-niMn8wSCdwu_p6fArq+Vd6kb-0EA@mail.gmail.com>
On Tuesday 04 June 2013 17:21:16 Andy Shevchenko wrote:
> > The easiest solution would be to
> > make the entire driver "depend on NET".
>
> I don't feel that is good idea. Driver is an abstraction to the ROM,
> it doesn't mean you can't read ROM without network framework.
Right, makes sense.
> It seems proper solution is to move mac_pton() outside of CONFIG_NET,
> though I don't know how to do this easily.
If we want to use it outside of CONFIG_NET, it cannot be part of net/core/*.c.
Maybe we can move the function to lib/mac_pton.c instead and create a
Kconfig symbol that gets selected by CONFIG_NET and by any driver lib
PCH_PHUB that needs it.
Arnd
next prev parent reply other threads:[~2013-06-04 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 15:54 [PATCH, resend] pch_phub: re-use native MAC address parser Andy Shevchenko
2013-06-04 14:03 ` Arnd Bergmann
2013-06-04 14:21 ` Andy Shevchenko
2013-06-04 14:38 ` Arnd Bergmann [this message]
2013-06-04 14:57 ` Andy Shevchenko
2013-06-04 15:12 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3489856.nvZgTyoe0K@wuerfel \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox