From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754858AbbLGBBb (ORCPT ); Sun, 6 Dec 2015 20:01:31 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:46383 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754051AbbLGBB3 (ORCPT ); Sun, 6 Dec 2015 20:01:29 -0500 From: "Rafael J. Wysocki" To: Greg Kroah-Hartman , Andy Shevchenko Cc: Andy Shevchenko , "linux-acpi@vger.kernel.org" , Vinod Koul , dmaengine , Thomas Gleixner , Jarkko Nikula , "linux-kernel@vger.kernel.org" , Mika Westerberg Subject: Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification Date: Mon, 07 Dec 2015 02:31:25 +0100 Message-ID: <3490462.ARevfiQkZD@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151205163622.GA2237@kroah.com> References: <1449265765-9393-1-git-send-email-andriy.shevchenko@linux.intel.com> <20151205163622.GA2237@kroah.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, December 05, 2015 08:36:22 AM Greg Kroah-Hartman wrote: > On Sat, Dec 05, 2015 at 06:24:05PM +0200, Andy Shevchenko wrote: > > On Sat, Dec 5, 2015 at 6:14 PM, Greg Kroah-Hartman > > wrote: > > > On Fri, Dec 04, 2015 at 11:49:17PM +0200, Andy Shevchenko wrote: > > >> The users of BUS_NOTIFY_BIND_DRIVER have no chance to do any cleanup in case of > > >> a probe failure. In the result there might be problems, such as some resources > > >> that had been allocated will continue to be allocated and therefore lead to a > > >> resource leak. > > >> > > >> Introduce a new notification to inform the subscriber that ->probe() failed. Do > > >> the same in case of failed device_bind_driver() call. > > > > > > Ugh, I hate all these notifiers, but this one does make sense... > > > > Yeah, I'm not a fan of them either. > > > > > Signed-off-by: Greg Kroah-Hartman > > > > You meant Acked-by, didn't you? > > Either works :) Thanks! Andy, what about if I put patches [1-6/9] into my queue for v4.5 now and the remaining ones will wait for Vinod to comment? Thanks, Rafael