From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
frankc@nvidia.com, hverkuil@xs4all.nl, sakari.ailus@iki.fi,
helen.koike@collabora.com
Cc: sboyd@kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v11 6/9] media: tegra: Add Tegra210 Video input driver
Date: Thu, 30 Apr 2020 16:38:37 +0300 [thread overview]
Message-ID: <34a49a30-71f2-5b24-20a4-7d98ae37cefa@gmail.com> (raw)
In-Reply-To: <1588197606-32124-7-git-send-email-skomatineni@nvidia.com>
30.04.2020 01:00, Sowjanya Komatineni пишет:
> +/**
> + * struct tegra_csi_ops - Tegra CSI operations
> + *
> + * @csi_streaming: programs csi hardware to enable or disable streaming.
> + * @csi_err_recover: csi hardware block recovery in case of any capture errors
> + * due to missing source stream or due to improper csi input from
> + * the external source.
> + */
> +struct tegra_csi_ops {
> + int (*csi_streaming)(struct tegra_csi_channel *csi_chan, u8 pg_mode,
> + int enable);
What about to split csi_streaming() into csi_start_streaming() /
csi_stop_streaming()?
This will make tegra_csi_ops to be consistent with the tegra_ve_ops. A
separated start/stop operations are somewhat more natural to have in
general.
next prev parent reply other threads:[~2020-04-30 13:38 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 21:59 [RFC PATCH v11 0/9] Add Tegra driver for video capture Sowjanya Komatineni
2020-04-29 21:59 ` [RFC PATCH v11 1/9] arm64: tegra: Fix sor powergate clocks and reset Sowjanya Komatineni
2020-04-29 21:59 ` [RFC PATCH v11 2/9] arm64: tegra: Add reset-cells to mc Sowjanya Komatineni
2020-04-29 22:00 ` [RFC PATCH v11 3/9] dt-bindings: clock: tegra: Add clk id for CSI TPG clock Sowjanya Komatineni
2020-04-29 22:00 ` [RFC PATCH v11 4/9] clk: tegra: Add Tegra210 CSI TPG clock gate Sowjanya Komatineni
2020-04-29 22:00 ` [RFC PATCH v11 5/9] dt-binding: tegra: Add VI and CSI bindings Sowjanya Komatineni
2020-04-29 22:00 ` [RFC PATCH v11 6/9] media: tegra: Add Tegra210 Video input driver Sowjanya Komatineni
2020-04-30 13:34 ` Dmitry Osipenko
2020-04-30 19:27 ` Sowjanya Komatineni
2020-04-30 13:38 ` Dmitry Osipenko [this message]
2020-04-30 19:32 ` Sowjanya Komatineni
2020-04-30 19:47 ` Dmitry Osipenko
2020-04-30 19:51 ` Sowjanya Komatineni
2020-04-30 13:43 ` Dmitry Osipenko
2020-04-30 13:46 ` Dmitry Osipenko
2020-04-30 13:56 ` Dmitry Osipenko
2020-04-30 14:02 ` Dmitry Osipenko
2020-04-30 14:13 ` Dmitry Osipenko
2020-04-30 16:04 ` Sowjanya Komatineni
2020-04-30 16:29 ` Sowjanya Komatineni
2020-04-30 17:06 ` Sowjanya Komatineni
2020-04-30 18:18 ` Sowjanya Komatineni
2020-04-30 19:09 ` Sowjanya Komatineni
2020-04-30 19:33 ` Dmitry Osipenko
2020-04-30 19:46 ` Sowjanya Komatineni
2020-04-30 19:53 ` Sowjanya Komatineni
2020-04-30 20:02 ` Sowjanya Komatineni
2020-04-30 21:17 ` Dmitry Osipenko
2020-04-30 21:26 ` Sowjanya Komatineni
2020-04-30 21:37 ` Sowjanya Komatineni
2020-04-30 21:53 ` Sowjanya Komatineni
2020-04-30 22:16 ` Sowjanya Komatineni
2020-04-30 22:19 ` Sowjanya Komatineni
2020-04-30 23:14 ` Sowjanya Komatineni
[not found] ` <fe7ebad6-0368-b1f0-4f58-648baa5e3f79@nvidia.com>
[not found] ` <4f095181-2338-3b71-316c-f8bbfc7865cc@nvidia.com>
[not found] ` <50e872bb-913a-7b47-3264-af6b1cedb0e2@nvidia.com>
[not found] ` <e17a8a49-be53-465d-f64c-3f4c77391d98@nvidia.com>
[not found] ` <da5154b4-85f9-3e56-a440-f75debaec3a8@nvidia.com>
[not found] ` <cbb047ae-97dc-8b9a-a5ba-8e2a5dab3771@nvidia.com>
[not found] ` <6ae2d00d-7955-d12b-5b56-955ef72ece26@nvidia.com>
2020-05-02 15:16 ` Dmitry Osipenko
2020-05-02 15:38 ` Sowjanya Komatineni
2020-05-02 16:03 ` Sowjanya Komatineni
2020-05-02 16:14 ` Sowjanya Komatineni
2020-05-02 16:55 ` Sowjanya Komatineni
2020-05-02 17:04 ` Sowjanya Komatineni
2020-05-02 19:14 ` Sowjanya Komatineni
2020-05-02 20:48 ` Dmitry Osipenko
2020-05-02 22:46 ` Sowjanya Komatineni
2020-05-03 0:03 ` Sowjanya Komatineni
2020-05-04 12:18 ` Hans Verkuil
2020-05-04 14:50 ` Sowjanya Komatineni
2020-04-30 21:22 ` Sowjanya Komatineni
[not found] ` <960d2715-a717-0cc3-df19-ff78dc426535@nvidia.com>
2020-05-04 15:53 ` Dmitry Osipenko
2020-05-04 15:56 ` Sowjanya Komatineni
2020-04-30 14:25 ` Dmitry Osipenko
2020-04-30 14:26 ` Dmitry Osipenko
2020-04-30 20:06 ` Dmitry Osipenko
2020-04-30 20:08 ` Sowjanya Komatineni
2020-04-30 20:09 ` Sowjanya Komatineni
2020-04-30 20:21 ` Dmitry Osipenko
2020-04-30 20:21 ` Sowjanya Komatineni
2020-05-04 7:44 ` Dmitry Osipenko
2020-05-04 14:36 ` Sowjanya Komatineni
2020-04-29 22:00 ` [RFC PATCH v11 7/9] MAINTAINERS: Add Tegra Video driver section Sowjanya Komatineni
2020-04-29 22:00 ` [RFC PATCH v11 8/9] dt-bindings: reset: Add ID for Tegra210 VI reset Sowjanya Komatineni
2020-04-29 22:00 ` [RFC PATCH v11 9/9] arm64: tegra: Add Tegra VI CSI support in device tree Sowjanya Komatineni
2020-04-30 9:59 ` [RFC PATCH v11 0/9] Add Tegra driver for video capture Hans Verkuil
2020-04-30 17:02 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34a49a30-71f2-5b24-20a4-7d98ae37cefa@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frankc@nvidia.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sboyd@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox