From: Florian Fainelli <f.fainelli@gmail.com>
To: Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Sasha Levin <sashal@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Russell King <linux@armlinux.org.uk>,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH stable 4.9 v2 0/4] ARM: ftrace MODULE_PLTS warning
Date: Fri, 24 Sep 2021 09:11:18 -0700 [thread overview]
Message-ID: <34ae79e3-f109-bc4b-341a-f05d95cf15e3@gmail.com> (raw)
In-Reply-To: <bb9fde7d-3644-6d30-c238-73427ab200e6@nokia.com>
On 9/24/21 8:27 AM, Alexander Sverdlin wrote:
> Hi Sasha,
>
> On 24/09/2021 13:52, Sasha Levin wrote:
>>>> This patch series is present in v5.14 and fixes warnings seen at insmod
>>>> with FTRACE and MODULE_PLTS enabled on ARM/Linux.
>>>
>>> All now queued up, thanks.
>>
>> Looks like 4.19 and older break the build:
>>
>> arch/arm/kernel/ftrace.c: In function 'ftrace_update_ftrace_func':
>> arch/arm/kernel/ftrace.c:157:9: error: too few arguments to function 'ftrace_call_replace'
>> 157 | new = ftrace_call_replace(pc, (unsigned long)func);
>> | ^~~~~~~~~~~~~~~~~~~
>
> in principle you can add ", true" as a third argument in all these ftrace_call_replace()
> call-sites which still have two args.
Sasha, what configuration failed to build? I build tested with
mutli_v7_defconfig which does enable FTRACE by default and then ensured
that CONFIG_ARM_MODULE_PLTS was enabled. From there I will re-submit,
sorry about that.
>
>> arch/arm/kernel/ftrace.c:99:22: note: declared here
>> 99 | static unsigned long ftrace_call_replace(unsigned long pc, unsigned long addr,
>> | ^~~~~~~~~~~~~~~~~~~
>> arch/arm/kernel/ftrace.c: In function 'ftrace_make_nop':
>> arch/arm/kernel/ftrace.c:240:9: error: too few arguments to function 'ftrace_call_replace'
>> 240 | old = ftrace_call_replace(ip, adjust_address(rec, addr));
>> | ^~~~~~~~~~~~~~~~~~~
>> arch/arm/kernel/ftrace.c:99:22: note: declared here
>> 99 | static unsigned long ftrace_call_replace(unsigned long pc, unsigned long addr,
>> | ^~~~~~~~~~~~~~~~~~~
>> make[2]: *** [scripts/Makefile.build:303: arch/arm/kernel/ftrace.o] Error 1
>>
>> I've dropped them.
>
--
Florian
next prev parent reply other threads:[~2021-09-24 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 17:02 [PATCH stable 4.9 v2 0/4] ARM: ftrace MODULE_PLTS warning Florian Fainelli
2021-09-22 17:02 ` [PATCH stable 4.9 v2 1/4] ARM: 9077/1: PLT: Move struct plt_entries definition to header Florian Fainelli
2021-09-22 17:02 ` [PATCH stable 4.9 v2 2/4] ARM: 9078/1: Add warn suppress parameter to arm_gen_branch_link() Florian Fainelli
2021-09-22 17:02 ` [PATCH stable 4.9 v2 3/4] ARM: 9079/1: ftrace: Add MODULE_PLTS support Florian Fainelli
2021-09-22 17:02 ` [PATCH stable 4.9 v2 4/4] ARM: 9098/1: ftrace: MODULE_PLT: Fix build problem without DYNAMIC_FTRACE Florian Fainelli
2021-09-23 10:35 ` [PATCH stable 4.9 v2 0/4] ARM: ftrace MODULE_PLTS warning Greg Kroah-Hartman
2021-09-24 11:52 ` Sasha Levin
2021-09-24 15:27 ` Alexander Sverdlin
2021-09-24 16:11 ` Florian Fainelli [this message]
2021-09-24 16:41 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34ae79e3-f109-bc4b-341a-f05d95cf15e3@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexander.sverdlin@nokia.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).