Re: [PATCH net-next v14 10/13] rtase: Implement ethtool function

Jakub Kicinski
2023-12-12T19:21:49Z

On Fri, 8 Dec 2023 17:47:30 +0800 Justin Lai wrote:
> +static const char rtase_gstrings[][ETH_GSTRING_LEN] = {
> + "tx_packets",
> + "rx_packets",
> + "tx_errors",
> + "rx_errors",
> + "rx_missed",
> + "align_errors",
> + "tx_single_collisions",
> + "tx_multi_collisions",
> + "unicast",
> + "broadcast",
> + "multicast",
> + "tx_aborted",
> + "tx_underrun",

Please take a look at struct rtnl_link_stats, anything that's already
present there should be reported via ndo_get_stats64, not ethtool