From: Florian Eckert <fe@dev.tdt.de>
To: m.brock@vanmierlo.com
Cc: Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org,
kabel@kernel.org, u.kleine-koenig@pengutronix.de,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-leds@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3 3/4] trigger: ledtrig-tty: move variable definition to the top
Date: Mon, 16 Oct 2023 11:12:15 +0200 [thread overview]
Message-ID: <34e8fcd94b4a959fe2336485e4722c3b@dev.tdt.de> (raw)
In-Reply-To: <93dcb9f6f218593084f834ba6b450999@vanmierlo.com>
On 2023-10-16 10:46, m.brock@vanmierlo.com wrote:
> Florian Eckert wrote on 2023-10-16 09:13:
>> Has complained about the following construct:
>
> Who is "Has" or who/what has complained?
The test robot who does not agree with my change in the v1 patchset.
>> drivers/leds/trigger/ledtrig-tty.c:362:3: error: a label can only be
>> part of a statement and a declaration is not a statement
>>
>> Hence move the variable definition to the beginning of the function.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes:
>> https://lore.kernel.org/oe-kbuild-all/202309270440.IJB24Xap-lkp@intel.com/
>> Signed-off-by: Florian Eckert <fe@dev.tdt.de>
>> ---
>> @@ -124,8 +125,6 @@ static void ledtrig_tty_work(struct work_struct
>> *work)
>>
>> if (icount.rx != trigger_data->rx ||
>> icount.tx != trigger_data->tx) {
>> - unsigned long interval = LEDTRIG_TTY_INTERVAL;
>> -
>
> Is this kernel test robot broken?
The test robot does nothing wrong.
> I see no label definition here.
> And this variable declaration is at the start of a new block which does
> not
> even require C99 support.
I made change in patch set v1, that moves the definition of the variable
`interval` into the switch case statement.
https://lore.kernel.org/linux-leds/20230926093607.59536-3-fe@dev.tdt.de/
The robot complained about this.
So I decided to move the definition of the variable 'interval' to
function
head to make the test robot happy in the commit. So this commit prepares
the code for my change.
If it is more common, I can merge this patch [1] into the next patch [2]
of this set.
[1]
https://lore.kernel.org/linux-leds/20231016071332.597654-4-fe@dev.tdt.de/
[2]
https://lore.kernel.org/linux-leds/20231016071332.597654-5-fe@dev.tdt.de/
Florian
next prev parent reply other threads:[~2023-10-16 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 7:13 [PATCH v3 0/4] ledtrig-tty: add additional tty state evaluation Florian Eckert
2023-10-16 7:13 ` [PATCH v3 1/4] tty: whitespaces in descriptions corrected by replacing tabs with spaces Florian Eckert
2023-10-16 12:32 ` Jiri Slaby
2023-10-18 10:56 ` Florian Eckert
2023-10-18 13:34 ` Greg KH
2023-10-16 7:13 ` [PATCH v3 2/4] tty: add new helper function tty_get_tiocm Florian Eckert
2023-10-16 7:13 ` [PATCH v3 3/4] trigger: ledtrig-tty: move variable definition to the top Florian Eckert
2023-10-16 8:46 ` m.brock
2023-10-16 9:12 ` Florian Eckert [this message]
2023-10-16 12:39 ` Jiri Slaby
2023-10-19 9:12 ` m.brock
2023-10-16 7:13 ` [PATCH v3 4/4] trigger: ledtrig-tty: add new line mode to triggers Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34e8fcd94b4a959fe2336485e4722c3b@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=Eckert.Florian@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=m.brock@vanmierlo.com \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox