From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbdEJNzz (ORCPT ); Wed, 10 May 2017 09:55:55 -0400 Received: from gloria.sntech.de ([95.129.55.99]:57124 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037AbdEJNzx (ORCPT ); Wed, 10 May 2017 09:55:53 -0400 From: Heiko Stuebner To: Kever Yang Cc: linux-rockchip@lists.infradead.org, Rob Herring , Shawn Lin , Huibin Hong , Elaine Zhang , Catalin Marinas , David Wu , Brian Norris , Jaehoon Chung , Douglas Anderson , Will Deacon , Matthias Brugger , devicetree@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, Jianqun Xu , linux-kernel@vger.kernel.org, Andy Yan , Caesar Wang , Mark Rutland , Roger Chen Subject: Re: [PATCH 3/4] ARM: dts: rockchip: use pin constants to describe IO in pinctrl Date: Wed, 10 May 2017 15:55:37 +0200 Message-ID: <3502373.tsXPg1D3p7@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: References: <1491981044-24635-1-git-send-email-kever.yang@rock-chips.com> <3966386.YQGqDXjHSp@phil> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kever, Am Mittwoch, 10. Mai 2017, 09:25:25 CEST schrieb Kever Yang: > On 05/10/2017 05:43 AM, Heiko Stuebner wrote: > > Am Mittwoch, 12. April 2017, 15:10:43 CEST schrieb Kever Yang: > >> Use command below to replace the IO naming in pinctrl: > >> sed -i -e 's/ 31 RK_FUNC_/ RK_PD7 RK_FUNC_/' arch/arm/boot/dts/rk* > >> sed -i -e 's/ 0 RK_FUNC_/ RK_PA0 RK_FUNC_/' > >> arch/arm64/boot/dts/rockchip/* > >> > >> Signed-off-by: Kever Yang > > I'm not sure, if we really want to mass-convert each and every pin. > > All pins in use right now seem to be working and it hides other > > history/blame for these entries. > > Do you mean you want to leave the code already there as is, and new > code using MACRO define for IO? > > This sounds reasonable, I can agree on this. I send this patch because I > see there is > a patch from Andy using MACRO for many IOs, but not complete enough > and my patch suppose to make all Rockchip IO has update. As I said, I'm really not sure. On the one hand it's nicer and it will be easier to check devicetree against schematics, but mass-converting them makes me anxious. Andy did convert the rk3288-popmetal board which is somewhat sparsely used I think. If anything breaks with Firefly, Rock, Veyron etc we might make a lot of people unhappy :-) . But having boards use both paradigms at the same time (pin number and names) could also be confusing. > > In any case though, this needs to be split into separate arm32/arm64 > > patches. Maybe we could split not only on the arm/arm64 border, but also on something like soc-level (rk3188, rk3288, rk3368). That way the amount of changes per patch would go down making review easier :-) . Just to make sure you saw it, I've also had to drop patch2 again (see separate response from yesterday). Heiko