From: David Howells <dhowells@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: torvalds@osdl.org, akpm@osdl.org, benh@kernel.crashing.org,
linux-kernel@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: [PATCH] Fix get_order()
Date: Tue, 06 Mar 2007 18:21:39 +0000 [thread overview]
Message-ID: <3523.1173205299@redhat.com> (raw)
In-Reply-To: <45EDABC8.8040901@zytor.com>
H. Peter Anvin <hpa@zytor.com> wrote:
> if (size <= (1UL << page_shift))
> return 0;
> else
> return __ilog2_u32(size-1)+1-page_shift;
I think you're right. That'll also defend against the result of __ilog2_u32()
being less than page_shift-1.
I think I can dispense with the page_shift argument. IIRC __get_order() was
overridden by some arch, but isn't now.
David
next prev parent reply other threads:[~2007-03-06 18:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 17:39 [PATCH] Fix get_order() David Howells
2007-03-06 17:58 ` H. Peter Anvin
2007-03-06 18:21 ` David Howells [this message]
2007-03-06 18:41 ` Linus Torvalds
2007-03-06 18:51 ` David Howells
2007-03-07 3:28 ` Linus Torvalds
2007-03-07 11:43 ` David Howells
2007-03-07 16:02 ` ALIGN via ilog2 without gccisms (Re: [PATCH] Fix get_order()) Oleg Verych
2007-03-07 16:38 ` Linus Torvalds
2007-03-07 17:24 ` Oleg Verych
2007-03-07 18:05 ` Linus Torvalds
2007-03-09 23:13 ` ALIGN " Oleg Verych
2007-03-09 23:15 ` Linus Torvalds
2007-03-10 0:31 ` Oleg Verych
2007-03-10 8:01 ` ALIGN Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3523.1173205299@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=hpa@zytor.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox