* [PATCH] selftests: intel_pstate: Fixes for the testing script run.sh
@ 2018-05-09 22:17 Jeffrin Jose T
2018-05-10 15:36 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Jeffrin Jose T @ 2018-05-09 22:17 UTC (permalink / raw)
To: shuah, kstewart, daniel.diaz, pombredanne, gregkh, thomas
Cc: linux-kselftest, linux-kernel, Jeffrin Jose T, Jeffrin Jose T
fix for notification of permission requirement to run test.
fix for exit status value for test skipped.
Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
---
tools/testing/selftests/intel_pstate/run.sh | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
index c670359becc6..74983f74a9a1 100755
--- a/tools/testing/selftests/intel_pstate/run.sh
+++ b/tools/testing/selftests/intel_pstate/run.sh
@@ -30,6 +30,13 @@
EVALUATE_ONLY=0
+msg="skip all tests:"
+
+if [ $UID != 0 ] && [ $EVALUATE_ONLY == 0 ]; then
+ echo $msg please run this as root >&2
+ exit $ksft_skip
+fi
+
if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then
echo "$0 # Skipped: Test can only run on x86 architectures."
exit 0
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: intel_pstate: Fixes for the testing script run.sh
2018-05-09 22:17 [PATCH] selftests: intel_pstate: Fixes for the testing script run.sh Jeffrin Jose T
@ 2018-05-10 15:36 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2018-05-10 15:36 UTC (permalink / raw)
To: Jeffrin Jose T, kstewart, daniel.diaz, pombredanne, gregkh,
thomas
Cc: linux-kselftest, linux-kernel, Jeffrin Jose T, Shuah Khan
On 05/09/2018 04:17 PM, Jeffrin Jose T wrote:
> fix for notification of permission requirement to run test.
> fix for exit status value for test skipped.
>
> Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
> ---
> tools/testing/selftests/intel_pstate/run.sh | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
> index c670359becc6..74983f74a9a1 100755
> --- a/tools/testing/selftests/intel_pstate/run.sh
> +++ b/tools/testing/selftests/intel_pstate/run.sh
> @@ -30,6 +30,13 @@
>
> EVALUATE_ONLY=0
>
> +msg="skip all tests:"
> +
> +if [ $UID != 0 ] && [ $EVALUATE_ONLY == 0 ]; then
> + echo $msg please run this as root >&2
> + exit $ksft_skip
> +fi
> +
> if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then
> echo "$0 # Skipped: Test can only run on x86 architectures."
> exit 0
>
I have a patch out for this and your change conflicts with it. I am in the process
of pushing patches into linux-kselftest next. Please rebase this patch on top
of that.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-10 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-09 22:17 [PATCH] selftests: intel_pstate: Fixes for the testing script run.sh Jeffrin Jose T
2018-05-10 15:36 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox