public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: platform: vsp1: vsp1_hsit:  Remove unused function
Date: Fri, 02 Jan 2015 14:09:58 +0200	[thread overview]
Message-ID: <3534952.jhm28o5kMm@avalon> (raw)
In-Reply-To: <1420134690-993-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

Hi Rickard,

Thank you for the patch.

On Thursday 01 January 2015 18:51:30 Rickard Strandqvist wrote:
> Remove the function vsp1_hsit_read() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called
> cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Acked-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

I've taken the patch in my tree and will send a pull request for v3.20.

> ---
>  drivers/media/platform/vsp1/vsp1_hsit.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_hsit.c
> b/drivers/media/platform/vsp1/vsp1_hsit.c index db2950a..9fb003b 100644
> --- a/drivers/media/platform/vsp1/vsp1_hsit.c
> +++ b/drivers/media/platform/vsp1/vsp1_hsit.c
> @@ -26,11 +26,6 @@
>   * Device Access
>   */
> 
> -static inline u32 vsp1_hsit_read(struct vsp1_hsit *hsit, u32 reg)
> -{
> -	return vsp1_read(hsit->entity.vsp1, reg);
> -}
> -
>  static inline void vsp1_hsit_write(struct vsp1_hsit *hsit, u32 reg, u32
> data) {
>  	vsp1_write(hsit->entity.vsp1, reg, data);

-- 
Regards,

Laurent Pinchart


      reply	other threads:[~2015-01-02 12:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-01 17:51 [PATCH] media: platform: vsp1: vsp1_hsit: Remove unused function Rickard Strandqvist
2015-01-02 12:09 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3534952.jhm28o5kMm@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=rickard_strandqvist@spectrumdigital.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox