* [PATCH] media: platform: vsp1: vsp1_hsit: Remove unused function
@ 2015-01-01 17:51 Rickard Strandqvist
2015-01-02 12:09 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-01 17:51 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Laurent Pinchart
Cc: Rickard Strandqvist, linux-media, linux-kernel
Remove the function vsp1_hsit_read() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/media/platform/vsp1/vsp1_hsit.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/media/platform/vsp1/vsp1_hsit.c b/drivers/media/platform/vsp1/vsp1_hsit.c
index db2950a..9fb003b 100644
--- a/drivers/media/platform/vsp1/vsp1_hsit.c
+++ b/drivers/media/platform/vsp1/vsp1_hsit.c
@@ -26,11 +26,6 @@
* Device Access
*/
-static inline u32 vsp1_hsit_read(struct vsp1_hsit *hsit, u32 reg)
-{
- return vsp1_read(hsit->entity.vsp1, reg);
-}
-
static inline void vsp1_hsit_write(struct vsp1_hsit *hsit, u32 reg, u32 data)
{
vsp1_write(hsit->entity.vsp1, reg, data);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: platform: vsp1: vsp1_hsit: Remove unused function
2015-01-01 17:51 [PATCH] media: platform: vsp1: vsp1_hsit: Remove unused function Rickard Strandqvist
@ 2015-01-02 12:09 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2015-01-02 12:09 UTC (permalink / raw)
To: Rickard Strandqvist, linux-media; +Cc: Mauro Carvalho Chehab, linux-kernel
Hi Rickard,
Thank you for the patch.
On Thursday 01 January 2015 18:51:30 Rickard Strandqvist wrote:
> Remove the function vsp1_hsit_read() that is not used anywhere.
>
> This was partially found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
I've taken the patch in my tree and will send a pull request for v3.20.
> ---
> drivers/media/platform/vsp1/vsp1_hsit.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_hsit.c
> b/drivers/media/platform/vsp1/vsp1_hsit.c index db2950a..9fb003b 100644
> --- a/drivers/media/platform/vsp1/vsp1_hsit.c
> +++ b/drivers/media/platform/vsp1/vsp1_hsit.c
> @@ -26,11 +26,6 @@
> * Device Access
> */
>
> -static inline u32 vsp1_hsit_read(struct vsp1_hsit *hsit, u32 reg)
> -{
> - return vsp1_read(hsit->entity.vsp1, reg);
> -}
> -
> static inline void vsp1_hsit_write(struct vsp1_hsit *hsit, u32 reg, u32
> data) {
> vsp1_write(hsit->entity.vsp1, reg, data);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-02 12:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-01 17:51 [PATCH] media: platform: vsp1: vsp1_hsit: Remove unused function Rickard Strandqvist
2015-01-02 12:09 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox