From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752750Ab1AQJdx (ORCPT ); Mon, 17 Jan 2011 04:33:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32116 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886Ab1AQJdu (ORCPT ); Mon, 17 Jan 2011 04:33:50 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <201101170039.p0H0d1f5085735@www262.sakura.ne.jp> References: <201101170039.p0H0d1f5085735@www262.sakura.ne.jp> <1295011682.7804.2.camel@localhost.localdomain> <201101142245.GGI86457.OQFFFMOtVOHJLS@I-love.SAKURA.ne.jp> <201101142307.EHC56742.FVtMFHOOFSQJOL@I-love.SAKURA.ne.jp> To: Tetsuo Handa Cc: dhowells@redhat.com, safford@watson.ibm.com, safford@us.ibm.com, jj@chaosbits.net, jmorris@namei.org, keyrings@linux-nfs.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] trusted-keys: another free memory bugfix Date: Mon, 17 Jan 2011 09:33:30 +0000 Message-ID: <3542.1295256810@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tetsuo Handa wrote: > From 94e965700f1e401408836d4aa782105483196842 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Mon, 17 Jan 2011 09:22:47 +0900 > Subject: [PATCH 1/3] trusted-keys: another free memory bugfix > > TSS_rawhmac() forgot to call va_end()/kfree() when data == NULL and > forgot to call va_end() when crypto_shash_update() < 0. > Fix these bugs by escaping from the loop using "break" > (rather than "return"/"goto") in order to make sure that > va_end()/kfree() are always called. > > Signed-off-by: Tetsuo Handa Acked-by: David Howells