Re: [PATCH 2/2] arm64: dts: rockchip: Add rk3528 QoS register node

Rob Herring
2025-03-05T17:17:26Z

On Wed, Mar 05, 2025 at 04:41:23PM +0100, Krzysztof Kozlowski wrote:
> On 05/03/2025 15:00, Chukun Pan wrote:
> > Copy QoS nodes and add rk3528 compatible from bsp kernel,
>
> No, don't copy stuff from BSP kernel. It results in terrible DTS.
>
> > these can be used for power-domain.
> >
> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3528.dtsi | 160 +++++++++++++++++++++++
> > 1 file changed, 160 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3528.dtsi b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> > index 5b334690356a..794f35654975 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> > @@ -122,6 +122,166 @@ gic: interrupt-controller@fed01000 {
> > #interrupt-cells = <3>;
> > };
> >
> > + qos_crypto_a: qos@ff200000 {
> > + compatible = "rockchip,rk3528-qos", "syscon";
> > + reg = <0x0 0xff200000 0x0 0x20>;
> > + };
> > +
> > + qos_crypto_p: qos@ff200080 {
> > + compatible = "rockchip,rk3528-qos", "syscon";
> > + reg = <0x0 0xff200080 0x0 0x20>;
> > + };
>
>
> Did you just define syscon per few registers? Third case last weeks...
> so no, define what is your device here. 8 registers is not a device usually.

Well, it is just a new compatible on top of existing 'qos' compatibles.
And in a quick scan I didn't see other things adjacent.