* [PATCH] [v2] clk: samsung: mark PM functions as __maybe_unused
@ 2020-12-04 15:27 Sylwester Nawrocki
2020-12-04 15:33 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Sylwester Nawrocki @ 2020-12-04 15:27 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: Tomasz Figa, Chanwoo Choi, Krzysztof Kozlowski, Arnd Bergmann,
linux-samsung-soc, linux-clk, linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The use of SIMPLE_DEV_PM_OPS() means that the suspend/resume
functions are now unused when CONFIG_PM is disabled:
drivers/clk/samsung/clk-exynos-clkout.c:219:12: error:
'exynos_clkout_resume' defined but not used [-Werror=unused-function]
219 | static int exynos_clkout_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~
drivers/clk/samsung/clk-exynos-clkout.c:210:12: error:
'exynos_clkout_suspend' defined but not used [-Werror=unused-function]
210 | static int exynos_clkout_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~
Mark them as __maybe_unused to shut up the otherwise harmless warning.
Fixes: 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module
driver")
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: add proper changelog text
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] [v2] clk: samsung: mark PM functions as __maybe_unused
2020-12-04 15:27 [PATCH] [v2] clk: samsung: mark PM functions as __maybe_unused Sylwester Nawrocki
@ 2020-12-04 15:33 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-04 15:33 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: Michael Turquette, Stephen Boyd, Tomasz Figa, Chanwoo Choi,
Arnd Bergmann, linux-samsung-soc@vger.kernel.org, linux-clk,
linux-arm-kernel, linux-kernel@vger.kernel.org
On Fri, 4 Dec 2020 at 16:28, Sylwester Nawrocki <snawrocki@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The use of SIMPLE_DEV_PM_OPS() means that the suspend/resume
> functions are now unused when CONFIG_PM is disabled:
>
> drivers/clk/samsung/clk-exynos-clkout.c:219:12: error:
> 'exynos_clkout_resume' defined but not used [-Werror=unused-function]
> 219 | static int exynos_clkout_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/clk/samsung/clk-exynos-clkout.c:210:12: error:
> 'exynos_clkout_suspend' defined but not used [-Werror=unused-function]
> 210 | static int exynos_clkout_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~
>
> Mark them as __maybe_unused to shut up the otherwise harmless warning.
>
> Fixes: 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module
> driver")
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: add proper changelog text
>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Indeed this should go via samsung soc tree...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CGME20201204091801epcas1p2a67474fad16d0c71f6b9a36cc72241ab@epcas1p2.samsung.com>]
* [PATCH] [v2] clk: samsung: mark PM functions as __maybe_unused
@ 2020-12-04 9:16 ` Arnd Bergmann
2020-12-04 9:45 ` Chanwoo Choi
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Arnd Bergmann @ 2020-12-04 9:16 UTC (permalink / raw)
To: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
Stephen Boyd, Krzysztof Kozlowski
Cc: Arnd Bergmann, linux-samsung-soc, linux-clk, linux-arm-kernel,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The use of SIMPLE_DEV_PM_OPS() means that the suspend/resume
functions are now unused when CONFIG_PM is disabled:
drivers/clk/samsung/clk-exynos-clkout.c:219:12: error: 'exynos_clkout_resume' defined but not used [-Werror=unused-function]
219 | static int exynos_clkout_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~
drivers/clk/samsung/clk-exynos-clkout.c:210:12: error: 'exynos_clkout_suspend' defined but not used [-Werror=unused-function]
210 | static int exynos_clkout_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~
Mark them as __maybe_unused to shut up the otherwise harmless warning.
Fixes: 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module driver")
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: add proper changelog text
---
drivers/clk/samsung/clk-exynos-clkout.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c
index 9ec2f40cc400..e6d6cbf8c4e6 100644
--- a/drivers/clk/samsung/clk-exynos-clkout.c
+++ b/drivers/clk/samsung/clk-exynos-clkout.c
@@ -207,7 +207,7 @@ static int exynos_clkout_remove(struct platform_device *pdev)
return 0;
}
-static int exynos_clkout_suspend(struct device *dev)
+static int __maybe_unused exynos_clkout_suspend(struct device *dev)
{
struct exynos_clkout *clkout = dev_get_drvdata(dev);
@@ -216,7 +216,7 @@ static int exynos_clkout_suspend(struct device *dev)
return 0;
}
-static int exynos_clkout_resume(struct device *dev)
+static int __maybe_unused exynos_clkout_resume(struct device *dev)
{
struct exynos_clkout *clkout = dev_get_drvdata(dev);
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] [v2] clk: samsung: mark PM functions as __maybe_unused
2020-12-04 9:16 ` Arnd Bergmann
@ 2020-12-04 9:45 ` Chanwoo Choi
2020-12-04 15:36 ` Sylwester Nawrocki
2020-12-05 14:14 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Chanwoo Choi @ 2020-12-04 9:45 UTC (permalink / raw)
To: Arnd Bergmann, Sylwester Nawrocki, Tomasz Figa, Michael Turquette,
Stephen Boyd, Krzysztof Kozlowski
Cc: Arnd Bergmann, linux-samsung-soc, linux-clk, linux-arm-kernel,
linux-kernel
On 12/4/20 6:16 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The use of SIMPLE_DEV_PM_OPS() means that the suspend/resume
> functions are now unused when CONFIG_PM is disabled:
>
> drivers/clk/samsung/clk-exynos-clkout.c:219:12: error: 'exynos_clkout_resume' defined but not used [-Werror=unused-function]
> 219 | static int exynos_clkout_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/clk/samsung/clk-exynos-clkout.c:210:12: error: 'exynos_clkout_suspend' defined but not used [-Werror=unused-function]
> 210 | static int exynos_clkout_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~
>
> Mark them as __maybe_unused to shut up the otherwise harmless warning.
>
> Fixes: 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module driver")
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: add proper changelog text
> ---
> drivers/clk/samsung/clk-exynos-clkout.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c
> index 9ec2f40cc400..e6d6cbf8c4e6 100644
> --- a/drivers/clk/samsung/clk-exynos-clkout.c
> +++ b/drivers/clk/samsung/clk-exynos-clkout.c
> @@ -207,7 +207,7 @@ static int exynos_clkout_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static int exynos_clkout_suspend(struct device *dev)
> +static int __maybe_unused exynos_clkout_suspend(struct device *dev)
> {
> struct exynos_clkout *clkout = dev_get_drvdata(dev);
>
> @@ -216,7 +216,7 @@ static int exynos_clkout_suspend(struct device *dev)
> return 0;
> }
>
> -static int exynos_clkout_resume(struct device *dev)
> +static int __maybe_unused exynos_clkout_resume(struct device *dev)
> {
> struct exynos_clkout *clkout = dev_get_drvdata(dev);
>
>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] [v2] clk: samsung: mark PM functions as __maybe_unused
2020-12-04 9:16 ` Arnd Bergmann
2020-12-04 9:45 ` Chanwoo Choi
@ 2020-12-04 15:36 ` Sylwester Nawrocki
2020-12-05 14:14 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2020-12-04 15:36 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: Arnd Bergmann, Tomasz Figa, Chanwoo Choi, Krzysztof Kozlowski,
Arnd Bergmann, linux-samsung-soc, linux-clk, linux-arm-kernel,
linux-kernel
On 12/4/20 10:16, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The use of SIMPLE_DEV_PM_OPS() means that the suspend/resume
> functions are now unused when CONFIG_PM is disabled:
>
> drivers/clk/samsung/clk-exynos-clkout.c:219:12: error: 'exynos_clkout_resume' defined but not used [-Werror=unused-function]
> 219 | static int exynos_clkout_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/clk/samsung/clk-exynos-clkout.c:210:12: error: 'exynos_clkout_suspend' defined but not used [-Werror=unused-function]
> 210 | static int exynos_clkout_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~
>
> Mark them as __maybe_unused to shut up the otherwise harmless warning.
>
> Fixes: 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module driver")
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: add proper changelog text
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] [v2] clk: samsung: mark PM functions as __maybe_unused
2020-12-04 9:16 ` Arnd Bergmann
2020-12-04 9:45 ` Chanwoo Choi
2020-12-04 15:36 ` Sylwester Nawrocki
@ 2020-12-05 14:14 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-05 14:14 UTC (permalink / raw)
To: Sylwester Nawrocki, Michael Turquette, Stephen Boyd, Chanwoo Choi,
Tomasz Figa, Arnd Bergmann
Cc: Krzysztof Kozlowski, linux-samsung-soc, linux-kernel,
Arnd Bergmann, linux-clk, linux-arm-kernel
On Fri, 4 Dec 2020 10:16:11 +0100, Arnd Bergmann wrote:
> The use of SIMPLE_DEV_PM_OPS() means that the suspend/resume
> functions are now unused when CONFIG_PM is disabled:
>
> drivers/clk/samsung/clk-exynos-clkout.c:219:12: error: 'exynos_clkout_resume' defined but not used [-Werror=unused-function]
> 219 | static int exynos_clkout_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/clk/samsung/clk-exynos-clkout.c:210:12: error: 'exynos_clkout_suspend' defined but not used [-Werror=unused-function]
> 210 | static int exynos_clkout_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~
>
> [...]
Applied, thanks!
[1/1] clk: samsung: mark PM functions as __maybe_unused
commit: 4c44274ee457e3f7012dc532c8c9cc8964a82612
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-05 15:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-04 15:27 [PATCH] [v2] clk: samsung: mark PM functions as __maybe_unused Sylwester Nawrocki
2020-12-04 15:33 ` Krzysztof Kozlowski
[not found] <CGME20201204091801epcas1p2a67474fad16d0c71f6b9a36cc72241ab@epcas1p2.samsung.com>
2020-12-04 9:16 ` Arnd Bergmann
2020-12-04 9:45 ` Chanwoo Choi
2020-12-04 15:36 ` Sylwester Nawrocki
2020-12-05 14:14 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox