Re: [PATCH 00/31] [PATCH 00/31] staging/wfx: usual maintenance

Kari Argillander
2021-09-10T17:07:52Z

On Fri, Sep 10, 2021 at 06:04:33PM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> Hi,
>
> The following PR contains now usual maintenance for the wfx driver. I have
> more-or-less sorted the patches by importance:
> - the first ones are fixes for a few corner-cases reported by users
> - the patches 9 and 10 add support for CSA and TDLS
> - then the end of the series is mostly cosmetics and nitpicking

Nicely formated patch series. Should be pretty easy to review. I just
check for fast eyes. But overall nice clean up series.

>
> I have wait longer than I initially wanted before to send this PR. It is
> because didn't want to conflict with the PR currently in review[1] to
> relocate this driver into the main tree. However, this PR started to be
> very large and nothing seems to move on main-tree side so I decided to not
> wait longer.
>
> Kalle, I am going to send a new version of [1] as soon as this PR will be
> accepted. I hope you will have time to review it one day :-).
>
> [1] https://lore.kernel.org/all/20210315132501.441681-1-Jerome.Pouiller@silabs.com/
>
> Jérôme Pouiller (31):
> staging: wfx: use abbreviated message for "incorrect sequence"
> staging: wfx: do not send CAB while scanning
> staging: wfx: ignore PS when STA/AP share same channel
> staging: wfx: wait for SCAN_CMPL after a SCAN_STOP
> staging: wfx: avoid possible lock-up during scan
> staging: wfx: drop unused argument from hif_scan()
> staging: wfx: fix atomic accesses in wfx_tx_queue_empty()
> staging: wfx: take advantage of wfx_tx_queue_empty()
> staging: wfx: declare support for TDLS
> staging: wfx: fix support for CSA
> staging: wfx: relax the PDS existence constraint
> staging: wfx: simplify API coherency check
> staging: wfx: update with API 3.8
> staging: wfx: uniformize counter names
> staging: wfx: fix misleading 'rate_id' usage
> staging: wfx: declare variables at beginning of functions
> staging: wfx: simplify hif_join()
> staging: wfx: reorder function for slightly better eye candy
> staging: wfx: fix error names
> staging: wfx: apply naming rules in hif_tx_mib.c
> staging: wfx: remove unused definition
> staging: wfx: remove useless debug statement
> staging: wfx: fix space after cast operator
> staging: wfx: remove references to WFxxx in comments
> staging: wfx: update files descriptions
> staging: wfx: reformat comment
> staging: wfx: avoid c99 comments
> staging: wfx: fix comments styles
> staging: wfx: remove useless comments after #endif
> staging: wfx: explain the purpose of wfx_send_pds()
> staging: wfx: indent functions arguments
>
> drivers/staging/wfx/bh.c | 33 +++----
> drivers/staging/wfx/bh.h | 4 +-
> drivers/staging/wfx/bus_sdio.c | 8 +-
> drivers/staging/wfx/bus_spi.c | 22 ++---
> drivers/staging/wfx/data_rx.c | 7 +-
> drivers/staging/wfx/data_rx.h | 4 +-
> drivers/staging/wfx/data_tx.c | 87 +++++++++--------
> drivers/staging/wfx/data_tx.h | 6 +-
> drivers/staging/wfx/debug.c | 54 ++++++-----
> drivers/staging/wfx/debug.h | 2 +-
> drivers/staging/wfx/fwio.c | 26 ++---
> drivers/staging/wfx/fwio.h | 2 +-
> drivers/staging/wfx/hif_api_cmd.h | 14 +--
> drivers/staging/wfx/hif_api_general.h | 25 ++---
> drivers/staging/wfx/hif_api_mib.h | 85 ++++++++--------
> drivers/staging/wfx/hif_rx.c | 23 ++---
> drivers/staging/wfx/hif_rx.h | 3 +-
> drivers/staging/wfx/hif_tx.c | 61 +++++-------
> drivers/staging/wfx/hif_tx.h | 6 +-
> drivers/staging/wfx/hif_tx_mib.c | 14 +--
> drivers/staging/wfx/hif_tx_mib.h | 2 +-
> drivers/staging/wfx/hwio.c | 6 +-
> drivers/staging/wfx/hwio.h | 20 ++--
> drivers/staging/wfx/key.c | 30 +++---
> drivers/staging/wfx/key.h | 4 +-
> drivers/staging/wfx/main.c | 39 +++++---
> drivers/staging/wfx/main.h | 3 +-
> drivers/staging/wfx/queue.c | 43 ++++----
> drivers/staging/wfx/queue.h | 6 +-
> drivers/staging/wfx/scan.c | 55 +++++++----
> drivers/staging/wfx/scan.h | 4 +-
> drivers/staging/wfx/sta.c | 135 +++++++++++++++-----------
> drivers/staging/wfx/sta.h | 8 +-
> drivers/staging/wfx/traces.h | 2 +-
> drivers/staging/wfx/wfx.h | 14 ++-
> 35 files changed, 457 insertions(+), 400 deletions(-)
>
> --
> 2.33.0
>