From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752107AbcBLKIA (ORCPT <rfc822;w@1wt.eu>);
	Fri, 12 Feb 2016 05:08:00 -0500
Received: from mout.kundenserver.de ([212.227.126.134]:59313 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751493AbcBLKH6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Feb 2016 05:07:58 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build
Date: Fri, 12 Feb 2016 11:07:11 +0100
Message-ID: <3557175.oOjJgCHd2P@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAK7LNAR8fJWPubucjw28gAPpF-4yvVMWZZ0F3j6VN4whGF9Yhw@mail.gmail.com>
References: <1455205297-1021302-1-git-send-email-arnd@arndb.de> <1455205297-1021302-5-git-send-email-arnd@arndb.de> <CAK7LNAR8fJWPubucjw28gAPpF-4yvVMWZZ0F3j6VN4whGF9Yhw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:a04Af+4zXb/EZeknmfkNtnml2RcbBd5jUEwuDd0EM4NREytJJtW
 w0cBX9DlX5Ed+qvPjSRQBFPtjbZ+ml6STrW+s7gsE7g3Yuv4KpxKKshTx2Rl+N7KUkO5z3x
 SHUjPUAsKKjj48PvzYuddjpCSltJdRm2qRcfZL7AhToYEM7IGQVCivSdmeRFO+3e3b7pKaa
 FWysh3O03Dmh3l+GAilzA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:E9hzGaPt4Mw=:oERBYwOi92gKfJ+a2gexzh
 fEsvBXMFmBFT5UjVkQvBuDxO7r0U8/VMiGxvMn6lEaa1eXLqqVOiAStupRNwq4zkSWuQcABCd
 8OL081Hmm4uEzSIRYPczdgaKL7fpl273KfnamDNvkzu1voVLO2nqwwKMpnMO+/B/vTRnF83Xz
 OcOrns4j9dQlsO0ytozHUrgM3FGwXNTcR2NDVrPG9Edj7M5N2BYIAcMh1gmfg2jUnunJPvh9Y
 ne6G8wRZV6mmGW5yc+RM2g4L2+B78H4N0+3XYNWbJOvfezx55Vr50IU78p4tUTWvHVnZl1ZMM
 Pz62SeK+kTffv1wUUlGs3PwRky0lLegv7rem0NEoU0BV6mz+YOIUBApJeRh92TmiIHBfywc+e
 UyhKlKS2dINvLH7XN3PvWlljslWVJsdjWm6kUTTwIV14QaGwoaO49HztdFJ32+t1EnrN6PkFq
 /JpOD+uCYBnBb933cRFbD0UAUAWPaaGUueI5SLcc2GdfZu2nu8lMLH0Bz3fTsngsH2/t/pNho
 9y5kQKzkCrlyvAvEri3/UdqzI24U7dwrFChZsN2hd873MJbC/HRbQxMkgdnOFurDy3blOtRHY
 kosoYEmL0JWFGiEYjgk3Nf4d3xd3z5sI+Vcjor0wn6o4K8/yuG6pZqpstanYRU7UAKKfbb9Rq
 FPRuRU8k1Aezez6LLi2uUrxp+6VW9ZsLnP0vWrQgu4DYLL23QCl88LMfk5bLp4Bd+Ch/qF8rF
 4lOe4WpQtpmQ6SNh
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 12 February 2016 18:37:08 Masahiro Yamada wrote:
> >  };
> >
> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
> >  static int __init uniphier_early_console_setup(struct earlycon_device *device,
> >                                                const char *options)
> >  {
> > --
> > 2.7.0
> >
> 
> I noticed commit 2eaa790989e03900298ad24f77f1086dbbc1aebd
> revived this link error, but I am not happy with seeing
> this patch again and again.
> 
> 
> Can you check this patch?
> https://patchwork.kernel.org/patch/8289231/
> 
> 
> 

Yes, I think your patch is nicer than mine. Let's see what the others
think, then I can resend my remaining patches on top of yours.

	Arnd