Re: [RFC][PATCH 0/5 v2] adv7511 EDID probing improvements

Archit Taneja
2016-12-12T08:40:53Z

Hi,

On 11/29/2016 10:34 AM, John Stultz wrote:
> Wanted to send out v2 of this patch set improving the EDID
> probing on the adv7511 used on HiKey.
>
> The first three patches are fixups that are hopefully straight
> forward, integrating feedback I got from Laurant.
>
> One of the previous patches that Laurant had concerns about, I
> broke into two patches, which are the last two in this series.
> The core issue seems to be something going wrong with the regmap
> cache state for the ADV7511_REG_EDID_I2C_ADDR (0x43) register
> which results in i2c_transfer errors if we don't do the
> regcache_sync/_mark_dirty() calls. I suspect there might be a
> better solution there, so suggestions will be very welcome.
>
> Thoughts and feedback would be appreciated!

I tested this for ADV7533 on DB410c and it works well. We can
pull this if it works fine for ADV7511 too. Laurent, could we
get an Ack for the series from you?

Thanks,
Archit

>
> thanks
> -john
>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Archit Taneja <architt@codeaurora.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: dri-devel@lists.freedesktop.org
>
> Archit Taneja (1):
> drm/bridge: adv7511: Enable HPD interrupts to support hotplug and
> improve monitor detection
>
> John Stultz (4):
> drm/bridge: adv7511: Use work_struct to defer hotplug handing to out
> of irq context
> drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event()
> drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be
> reused internally
> drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID
>
> drivers/gpu/drm/bridge/adv7511/adv7511.h | 2 ++
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 49 ++++++++++++++++------------
> 2 files changed, 31 insertions(+), 20 deletions(-)
>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project