From: Alexander Stein <alexander.stein@systec-electronic.com>
To: linux-kernel@vger.kernel.org
Cc: Yuan Yao <yao.yuan@freescale.com>,
vinod.koul@intel.com, robh+dt@kernel.org,
dan.j.williams@intel.com, mark.rutland@arm.com,
linux@armlinux.org.uk, shawnguo@kernel.org, leoyang.li@nxp.com,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Yuan Yao <yao.yuan@nxp.com>
Subject: Re: [PATCH v1 4/5] ARM: dts: ls1043a: add qDMA node
Date: Mon, 29 Aug 2016 09:34:16 +0200 [thread overview]
Message-ID: <3583547.0zriK9IoAs@ws-stein> (raw)
In-Reply-To: <1471502328-28305-5-git-send-email-yao.yuan@freescale.com>
On Thursday 18 August 2016 14:38:47, Yuan Yao wrote:
> From: Yuan Yao <yao.yuan@nxp.com>
>
> Add the QDMA node for ls1043a platform to
> support QDMA driver.
>
> Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index e8e4c3e..e463074
> 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -467,6 +467,16 @@
> <&clockgen 4 0>;
> };
>
> + qdma: qdma@8390000 {
> + compatible = "fsl,ls1021a-qdma", "fsl,ls1043a-qdma";
This doesn't match the order of your binding in Patch 2/5:
> +- compatible :
> + - "fsl,ls1021a-qdma",
> + Or "fsl,ls1043a-qdma" followed by "fsl,ls1021a-qdma",
It should be the other way around.
Best regards,
Alexander
next prev parent reply other threads:[~2016-08-29 7:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 6:38 [PATCH v1 0/5] dma: Add QorIQ qDMA engine driver support Yuan Yao
2016-08-18 6:38 ` [PATCH v1 1/5] " Yuan Yao
2016-08-18 9:16 ` Russell King - ARM Linux
2016-08-24 3:39 ` Yao Yuan
2016-08-23 12:18 ` kbuild test robot
2016-08-23 12:18 ` [PATCH] dma: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-08-18 6:38 ` [PATCH v1 2/5] dma: Add device tree binding for QorIQ qDMA driver Yuan Yao
2016-08-18 6:38 ` [PATCH v1 3/5] MAINTAINERS: add maintainer entry for QorIQ QDMA driver Yuan Yao
2016-08-18 6:38 ` [PATCH v1 4/5] ARM: dts: ls1043a: add qDMA node Yuan Yao
2016-08-29 7:29 ` Alexander Stein
2016-08-29 7:34 ` Alexander Stein [this message]
2016-08-31 4:17 ` Yao Yuan
2016-08-18 6:38 ` [PATCH v1 5/5] ARM: dts: ls1021a: " Yuan Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3583547.0zriK9IoAs@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vinod.koul@intel.com \
--cc=yao.yuan@freescale.com \
--cc=yao.yuan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox